Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update oneapi to 2025 #610

Closed
wants to merge 5 commits into from

Conversation

rscohn2
Copy link
Member

@rscohn2 rscohn2 commented Oct 31, 2024

Description

Update oneapi install to 2025. I removed setup-oneapi because I am not sure if I will be able to continue to maintain it. setup-oneapi used github caching to speed up install, but blas/lapack tests run for a long time and the acceleration doesn't matter so much. fft testing is much shorter so it will be slower.

@rscohn2 rscohn2 requested a review from a team as a code owner October 31, 2024 21:37
@sknepper
Copy link
Contributor

Thanks, @rscohn2 ! I know the LAPACK failures are expected until the changes in #606 are available.
Do you know what's happening with portBLAS and MKL BLAS failures? Do we need to extend a timeout or anything like that?

@rscohn2
Copy link
Member Author

rscohn2 commented Nov 1, 2024

Thanks, @rscohn2 ! I know the LAPACK failures are expected until the changes in #606 are available. Do you know what's happening with portBLAS and MKL BLAS failures? Do we need to extend a timeout or anything like that?

When you use a matrix to launch multiple jobs, the default behavior is to cancel all jobs if any fails. I pushed a change that will make it attempt to finish all jobs.

@rscohn2
Copy link
Member Author

rscohn2 commented Nov 1, 2024

It seems like the caching is not needed anymore. It used to take 5 minutes to install the compiler. Now it finishes in 68 seconds with no caching.

.github/workflows/pr.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will you be able to force merge the PR given that the GitHub CI will fail with the lapack domain?

Copy link
Contributor

@sknepper sknepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rscohn2 - looks good to me! If necessary, we can combine this PR with #606 to get passing CI.
Looking ahead, how is the correct URL for the registration center determined?

@rscohn2
Copy link
Member Author

rscohn2 commented Nov 1, 2024

Looking ahead, how is the correct URL for the registration center determined?

There are multiple ways to get the URL. This is what I found most convenient. Intel maintains the following files so they are updated at same time as other release channels.
mkl: https://github.com/spack/spack/blob/24d3ed8c1805ccd7553dba2c62984d99dc301f6e/var/spack/repos/builtin/packages/intel-oneapi-mkl/package.py#L28
compiler: https://github.com/spack/spack/blob/24d3ed8c1805ccd7553dba2c62984d99dc301f6e/var/spack/repos/builtin/packages/intel-oneapi-compilers/package.py#L16

Co-authored-by: Dai-Ni Hsieh <[email protected]>
Copy link
Contributor

@dnhsieh-intel dnhsieh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I learned that we need to use -s twice.

- name: Install Intel oneMKL
if: steps.domain_check.outputs.result == 'true'
run: |
wget https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed another wget...

Suggested change
wget https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh

@sknepper
Copy link
Contributor

sknepper commented Nov 4, 2024

As mentioned in #606 , I pulled in the changes from this PR (plus the change requested by @dnhsieh-intel ) into that PR and all of the CI tests are green there. So if we want to keep a green CI, we can merge them together. Thanks!!

@rscohn2
Copy link
Member Author

rscohn2 commented Nov 5, 2024

Closing, incorporated into #606

@rscohn2 rscohn2 closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants