Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ascii characters in files #103

Open
SebastianLuzynski opened this issue Nov 10, 2022 · 6 comments
Open

Non-ascii characters in files #103

SebastianLuzynski opened this issue Nov 10, 2022 · 6 comments

Comments

@SebastianLuzynski
Copy link

There are some non-ascii characters inside files. This may cause problems with linters requiring only ascii characters, and it's against most of style guides for C++.
fixed in #97

@bmyates
Copy link
Contributor

bmyates commented Nov 10, 2022

Hi thanks for pointing this out. This file is generated from https://github.com/oneapi-src/level-zero-spec/blob/master/scripts/templates/api.h.mako

Can you check if non-ascii character is in that file?

@SebastianLuzynski
Copy link
Author

image

@bmyates
Copy link
Contributor

bmyates commented Nov 10, 2022

Thanks! Please open issue/PR in the spec repo. After changes are accepted there, the files in this repo can be regenerated.

@SebastianLuzynski
Copy link
Author

@bmyates Commit to level zero spec has been merged.

@bmyates
Copy link
Contributor

bmyates commented Nov 30, 2022

Thanks, next release here will include the changes. We are currently waiting on 1.5 spec to be finalized. It is expected soon.

@eero-t
Copy link

eero-t commented Nov 21, 2023

@SebastianLuzynski If this issue is now resolved, could you either close the bug, or comment what's still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants