Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Instrument encoder #81

Open
stefanches7 opened this issue Oct 2, 2024 · 2 comments
Open

Add the Instrument encoder #81

stefanches7 opened this issue Oct 2, 2024 · 2 comments

Comments

@stefanches7
Copy link

I was just curious if there is any impediment to this, or things to consider here.
Currently, I am working around the lack of proper encoder here with using simpleMarshal() method in the API that provides the most important info, and then unwrapping OMERO objects using omero.rtypes.unwrap()

@will-moore
Copy link
Member

There's quite a few objects linked under Instrument (https://omero.readthedocs.io/en/stable/developers/Model/EveryObject.html#instrument) so it would need a bunch of new encoders.

You're using image.simpleMarshal() from https://github.com/ome/omero-py/blob/4fd72efaa8cdbec9da98e1d28678af16878a86ba/src/omero/gateway/__init__.py#L8260 and you have an Image with the Instrument loaded with your own query, or you're calling image.getInstrument() before image.simpleMarshal()?

@stefanches7
Copy link
Author

@will-moore thanks, I see why it is problematic now.
I am indeed using instrument = image.getInstrument() if instrument: m = instrument.simpleMarshal(),
so I am marshalling the Instrument object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants