Fix host breaking when set to only port #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that setting the host to only a port - see example below, would break the formatting and return a jumbled host
http://http:11434//127.0.0.1:11434
. I confirmed this is an issue on both Node and Deno, see attached images.Wrote a quick test for the formatted and tested 19 different variants - see attached image, which confirmed the issue was only present when passing in a port to
formatHost
.Setting
isExplicitProtocol
totrue
instead offalse
fixes this issue.