[IMP] runbot: reinforce version #852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
reviewed
Feb 21, 2024
runbot/views/bundle_views.xml
Outdated
| @@ -50,7 +50,8 @@ | |||
| <field name="project_id"/> | |||
| <field name="sticky" readonly="0"/> | |||
| <field name="to_upgrade" readonly="0"/> | |||
| <field name="is_base"/> | |||
| <field name="match_base" invisible="1"/> | |||
| <field name="is_base" invisible="not match_base"/> | |||
There was a problem hiding this comment.
I would put it visible but readonly in all cases
This is a useful visual information but it makes no sense to modify it most of the time.
When updating a bundle and changing the is_base field to True, it creates a new version based on the bundle name. This can potentially breaks builds and moreover, it can breaks the whole runbot when a duplicate version name is created. With this commit: - a constraint on the version name uniqueness is added - the is_base field is now readonky - a version cannot be created by the compute version if the version name does not match the above mentioned regular expression
d-fence
force-pushed
the
17.0-solidify-version-moc
branch
from
fca01cf
to
e07fcd6
Compare
Xavier-Do
force-pushed
the
17.0
branch
2 times, most recently
from
13e3d9d
to
e7d1cc9
Compare
Xavier-Do
reviewed
Jul 26, 2024
| @@ -25,6 +25,10 @@ class Version(models.Model): | |||
|
|
|||
| dockerfile_id = fields.Many2one('runbot.dockerfile', default=lambda self: self.env.ref('runbot.docker_default', raise_if_not_found=False)) | |||
|
|
|||
| _sql_constraints = [ | |||
There was a problem hiding this comment.
we should actually ensure number uniqueness too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a bundle and changing the is_base field to True, it creates a new version based on the bundle name. This can potentially breaks builds and moreover, it can breaks the whole runbot when a duplicate version name is created.
With this commit: