Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patcher: handle missing signature #992

Open
xmo-odoo opened this issue Nov 25, 2024 · 0 comments
Open

patcher: handle missing signature #992

xmo-odoo opened this issue Nov 25, 2024 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

Git supports format-patch --no-signature, and that makes the patcher very unhappy as all the content ends up in the third parameter of partition, so the patch data is empty, which is incorrect.

Also:

  • might be a good idea to convert windows line endings to unix? Might lead to breakage if we actually want windows line ends but that seems doubtful, apparently the ace widget adds windows line-ends on windows...
  • probably handle signature separators with just --\n
@xmo-odoo xmo-odoo moved this to accepted in Mergebot Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: accepted
Development

No branches or pull requests

1 participant