Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding new pull requests to an existing forward port #787

Open
xmo-odoo opened this issue Jun 29, 2023 · 0 comments
Open

Support adding new pull requests to an existing forward port #787

xmo-odoo opened this issue Jun 29, 2023 · 0 comments

Comments

@xmo-odoo
Copy link
Collaborator

Currently adding a new PR to an existing forward port sequence is not possible: the validation of the existing fw will trigger _port_forward which will immediately port the "true" forward ports to the next target.

After the batch gets merged, ForwardPortTasks._process_item runs, finds that at least one of the batch's PR was already forward ported, and bails on the entire thing (because already ported).

This can make it difficult to fix PRs which break some other things in their forward ports, or require further adaptations.

@xmo-odoo xmo-odoo mentioned this issue Jun 30, 2023
3 tasks
@xmo-odoo xmo-odoo moved this to done in Mergebot May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

No branches or pull requests

1 participant