Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] conditional_format: improve CF data bar behavior for non-matching range sizes #5164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rachico
Copy link
Contributor

@Rachico Rachico commented Nov 5, 2024

Before this commit, defining a CF data bar rule based on the value of another range requires both ranges to have matching sizes, preventing the CF from being created otherwise. This restriction leads to a poor user experience when copying and pasting CFs, as the CF does not get pasted.

This commit removes the restriction, allowing CF creation in a "best effort" manner when the range sizes do not match. The CF style is therefore applied by comparing the matching cells.

Task: 4280720

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 5, 2024

Pull request status dashboard

@Rachico Rachico force-pushed the master-improve-cf-bar-rule-mera branch 7 times, most recently from b4deef4 to 2641dd1 Compare November 7, 2024 10:04
@Rachico Rachico force-pushed the master-improve-cf-bar-rule-mera branch 3 times, most recently from 5fc35be to 4011cb6 Compare November 12, 2024 15:24
@Rachico Rachico force-pushed the master-improve-cf-bar-rule-mera branch from 4011cb6 to f8fd3c8 Compare November 13, 2024 13:16
…ng range sizes

Before this commit, defining a CF data bar rule based on the value of
another range requires both ranges to have matching sizes, preventing
the CF from being created otherwise. This restriction leads to a poor
user experience when copying and pasting CFs, as the CF does not get
pasted.

This commit removes the restriction, allowing CF creation in a "best effort"
manner when the range sizes do not match. The CF style is therefore applied by
comparing the matching cells.

Task: 4280720
@Rachico Rachico force-pushed the master-improve-cf-bar-rule-mera branch from f8fd3c8 to fc67664 Compare November 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants