[IMP] Clipboard: support images in the clipboard #5098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit adds the support of images in the clipboard. Namely,
the filestore and dispatch a CREATE_IMAGE accordingly.
oOS clipboard. It can then be pasted somewhere else, like a discuss
app, a text editor maybe?.
TODO
because we never check agains the actual type of the file we upload
but it's wrong. Maybe use a generic
image/*
mimetype instead of usingpng. We still need to purge out dangerous mimetypes like image/svg(+xml)
we are copy pasting from the same spreadsheet clipboard (potential
useless upload)
clipboard has some text/* types along the image/* so it ignores the
later. for a fully integrated feature, we should probably decorrelate it
from the standard copy paste and make a menu "copy image to os
clipboard" ? tbd
Task: 4241877
review checklist