Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] inventory: compare packs and uom #11424

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Felicious
Copy link
Contributor

Overview doc that compares UoM, packages, and packagings. Requested by Aurora (auca) to inform customers which features are suitable for their business while implementing Odoo with a BSA.

Also added section to detail the Move Entire Packages feature

Task
Fwport: yes, all the way to master (:

@Felicious Felicious self-assigned this Nov 20, 2024
@robodoo
Copy link
Collaborator

robodoo commented Nov 20, 2024

Pull request status dashboard

@Felicious
Copy link
Contributor Author

Hi @ksc-odoo ! This PR is ready for the first round of peer review. Since this is an analytical doc with few setup instructions, I'll also be following up with a product expert to ensure the concepts are explained properly

@C3POdoo C3POdoo requested a review from a team November 20, 2024 21:03
@Felicious Felicious force-pushed the 16.0-inventory-compare-uom-and-packs-feku branch from 6a0ec80 to c1c632c Compare November 21, 2024 18:48
@Felicious
Copy link
Contributor Author

Implemented suggests from AUCA and BRHE to add a column for UoM in the comparison section, as well as improve the first use case for clarity. Consulted Inventory smartclass content to come up with the third use case about fruit juice (:

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Felicious -- just finished my Peer Review of this PR. Great work! Really detailed and smooth throughout. Once you address my comments, and implement the necessary changes, feel free to move this to the next stage. Once again -- awesome job! 👍

(e.g., meters, yards, kilograms). Enables automatic conversion between measurement systems in
Odoo, such as centimeters to feet.

- *Ex: Purchasing fabric measured in meters but receiving it in yards from a vendor.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this, and the following examples, be reformatted as 'Example' admonitions? What are your thoughts?

.. list-table::
:header-rows: 1
:stub-columns: 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the following table, I'd suggest considering the removal of periods attached to incomplete sentences; falling in line with our formatting guidelines when dealing with such explanatory lines (e.g. removing periods when a complete sentence isn't used following a colon). Just something to consider during your revision

- Tracks product quantities within the warehouse in the specific |UoM| defined in the product
form.
- Tracks package location and contents within the warehouse.
- Tracks grouped quantities but not individual items' locations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tracks grouped quantities but not individual items' locations.
- Tracks grouped quantities, but not individual items' locations.

OPTIONAL; added comma to enhance the pacing of the sentence

- Tracks grouped quantities but not individual items' locations.
* - Smooth barcode operations
- Not available.
- Requires scanning both the package and individual items for reception. (even if there are 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Requires scanning both the package and individual items for reception. (even if there are 30
- Requires scanning both the package and individual items for reception (even if there are 30

items in a package). Can enable the :ref:`Move Entire Packages
<inventory/product_management/move-entire-pack>` feature to update the package's contained
items' locations, when moving the package
- Scanning a packaging barcode automatically records all included units. (e.g., 1 pack = 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Scanning a packaging barcode automatically records all included units. (e.g., 1 pack = 12
- Scanning a packaging barcode automatically records all included units. (e.g. 1 pack = 12

only need the comma after 'e.g.' when more than one example follows.

Capturing product information using barcode
-------------------------------------------

An Odoo user expects the Barcode app to display the typical storage location of a product by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An Odoo user expects the Barcode app to display the typical storage location of a product by
An Odoo user expects the **Barcode** app to display the typical storage location of a product by

An Odoo user expects the Barcode app to display the typical storage location of a product by
scanning a barcode for a container.

**Packages** was the most suitable. When the :ref:`appropriate setting is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Packages** was the most suitable. When the :ref:`appropriate setting is enabled
*Packages* was the most suitable. When the :ref:`appropriate setting is enabled

optional: opting for italics here to allude to an option within an app. Also, it helps differentiate it from the bolded app name used in the prior sentence.

Comment on lines +138 to +140
the Barcode app. Packages represent physical containers, enabling detailed tracking of the items
they hold. Scanning a package provides visibility into its contents and facilitates operations like
inventory moves.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the Barcode app. Packages represent physical containers, enabling detailed tracking of the items
they hold. Scanning a package provides visibility into its contents and facilitates operations like
inventory moves.
the **Barcode** app.
Packages represent physical containers, enabling detailed tracking of the items they hold.
Scanning a package provides visibility into its contents and facilitates operations, like inventory
moves.

- Juice is produced and stored in kilograms.
- Small samples are stored in grams for recipe testing.

**Unit of Measure** was most suitable. Odoo automatically converts tons to kilograms during
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Unit of Measure** was most suitable. Odoo automatically converts tons to kilograms during
*Unit of Measure* was most suitable. Odoo automatically converts tons to kilograms during

optional: opting for italics here to allude to an option within an app. Also, it helps differentiate it from the bolded app name used in the prior sentence.

type to update a package's contained item's location upon updating the package's location.

To do that, go to :menuselection:`Inventory app --> Configuration --> Operations Types` and select
the desired operation that this feature will apply to. (May have to set it for multiple)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the desired operation that this feature will apply to. (May have to set it for multiple)
the desired operation this feature will apply to (may have to set it for multiple).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants