feat(ConnectSession): add method nullSafeGetSkipPermissionCheck, add param maxConcurrentTaskCount in createPhysicalConnectionSession #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd param maxConcurrentTaskCount in createPhysicalConnectionSession
LioRoger
reviewed
Nov 29, 2024
| if (createConnectionSessionSupplier == null) { | ||
| throw new NotFoundException(ResourceType.ODC_SESSION, "ID", sessionId); | ||
| } | ||
| Lock lock = this.sessionId2Lock.computeIfAbsent(sessionId, s -> new ReentrantLock()); |
There was a problem hiding this comment.
this lock logic can't protect session acquire in same behavior
- if first attempt get session failed, code goto line 408, but session is created ,will this session should be cancelExpire? if not so, this may cause session used by multi user
- each session id will create a lock in sessionId2Lock, this will cause memory leak, is that expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dd param maxConcurrentTaskCount in createPhysicalConnectionSession
What type of PR is this?
type-feature
What this PR does / why we need it:
support execute chart
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: