Feature/delete account #142

piotrstanny · 2020-12-11T14:39:15Z

Description

Please include a brief summary of what the issue is and what has been done to solve it

Fixes #83

Checklist:

Creator

The target branch is dev
I have updated the unreleased section of the change log
I have reviewed the 'files changed' tab on github to ensure all changes are as expected
I have added someone to review the pr

Reviewer

I have verified the above are all completed
I have run the code locally to ensure it fufills the requirements of the issue
I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

If appropriate I have closed the issue

… were fired on click

JElgar

Hello thank you for this @piotrstanny
This looks great, the service looks perfect but can we add-in a little bit extra error handling to the viewmodel. If you want you could also customize the error depending on the status code in service and then give different messages for different types of errors.

One other git thing is I'm not sure why there are so many file changes to the ios folder?

JElgar · 2020-12-11T22:20:57Z

ios/Flutter/Generated.xcconfig

 // This is a generated file; do not edit or check into version control.
-FLUTTER_ROOT=/Users/tristanclarke/development/flutter
-FLUTTER_APPLICATION_PATH=/Users/tristanclarke/development/github.com/now-u/now-u-app
-FLUTTER_TARGET=/Users/tristanclarke/development/github.com/now-u/now-u-app/lib/main.dart
+FLUTTER_ROOT=/Users/piotrstanny/flutterdev/flutter
+FLUTTER_APPLICATION_PATH=/Users/piotrstanny/AndroidStudioProjects/now-u-app
+FLUTTER_TARGET=/Users/piotrstanny/AndroidStudioProjects/now-u-app/lib/main.dart
 FLUTTER_BUILD_DIR=build
 SYMROOT=${SOURCE_ROOT}/../build/ios
 OTHER_LDFLAGS=$(inherited) -framework Flutter
-FLUTTER_FRAMEWORK_DIR=/Users/tristanclarke/development/flutter/bin/cache/artifacts/engine/ios
-FLUTTER_BUILD_NAME=1.0.9
-FLUTTER_BUILD_NUMBER=20
+FLUTTER_BUILD_NAME=1.1.9
+FLUTTER_BUILD_NUMBER=33
+DART_DEFINES=flutter.inspector.structuredErrors%3Dtrue
+DART_OBFUSCATION=false
 TRACK_WIDGET_CREATION=true
-DART_DEFINES=flutter.inspector.structuredErrors=true
+TREE_SHAKE_ICONS=false
+PACKAGE_CONFIG=/Users/piotrstanny/AndroidStudioProjects/now-u-app/.dart_tool/package_config.json


I think we should add this to the git ignore

JElgar · 2020-12-11T22:21:15Z

ios/Flutter/flutter_export_environment.sh

 #!/bin/sh
 # This is a generated file; do not edit or check into version control.
-export "FLUTTER_ROOT=/Users/tristanclarke/development/flutter"
-export "FLUTTER_APPLICATION_PATH=/Users/tristanclarke/development/github.com/now-u/now-u-app"
-export "FLUTTER_TARGET=/Users/tristanclarke/development/github.com/now-u/now-u-app/lib/main.dart"
+export "FLUTTER_ROOT=/Users/piotrstanny/flutterdev/flutter"
+export "FLUTTER_APPLICATION_PATH=/Users/piotrstanny/AndroidStudioProjects/now-u-app"
+export "FLUTTER_TARGET=/Users/piotrstanny/AndroidStudioProjects/now-u-app/lib/main.dart"
 export "FLUTTER_BUILD_DIR=build"
 export "SYMROOT=${SOURCE_ROOT}/../build/ios"
 export "OTHER_LDFLAGS=$(inherited) -framework Flutter"
-export "FLUTTER_FRAMEWORK_DIR=/Users/tristanclarke/development/flutter/bin/cache/artifacts/engine/ios"
-export "FLUTTER_BUILD_NAME=1.0.9"
-export "FLUTTER_BUILD_NUMBER=20"
+export "FLUTTER_BUILD_NAME=1.1.9"
+export "FLUTTER_BUILD_NUMBER=33"
+export "DART_DEFINES=flutter.inspector.structuredErrors%3Dtrue"
+export "DART_OBFUSCATION=false"
 export "TRACK_WIDGET_CREATION=true"
-export "DART_DEFINES=flutter.inspector.structuredErrors=true"
+export "TREE_SHAKE_ICONS=false"
+export "PACKAGE_CONFIG=/Users/piotrstanny/AndroidStudioProjects/now-u-app/.dart_tool/package_config.json"


JElgar · 2020-12-12T11:33:16Z

lib/services/auth.dart

+  Future<bool> deleteUserAccount() async {
+    try {
+      http.Response response = await http.delete(
+        domainPrefix + 'users/me',
+        headers: <String, String>{
+          'Content-Type': 'application/json; charset=UTF-8',
+          'token': currentUser.getToken(),
+        },
+      );
+      if (response.statusCode != 200) {
+        print("Returned false, no error but status not 200");
+        return false;
+      }
+      print("Returned true, account should be deleted");
+      return true;
+    } catch (e) {
+      print("Error");
      return false;
    }


JElgar · 2020-12-12T11:35:07Z

lib/viewmodels/account_details_model.dart

+
+  void delete() async {
+    setBusy(true);
+    await _authenticationService.deleteUserAccount();


Can we add some error handling in here?

So for example

Suggested change

await _authenticationService.deleteUserAccount();

if (!await _authenticationService.deleteUserAccount()) {

_dialog_service -> something when wrong message

} else {

await _analyticsService.logUserAccountDeleted();

logout();

}

JElgar

One other thing we should think about is testing. I think it would be nice if we make sure we add tests for each new feature we are working on. Let have a chat about this after Christmas though as I think this is gonna require some thinking?

piotrstanny · 2020-12-15T17:29:48Z

One other thing we should think about is testing. I think it would be nice if we make sure we add tests for each new feature we are working on. Let have a chat about this after Christmas though as I think this is gonna require some thinking?

Yes definitely agree. And as you say we can explore the topic after Christmas.

test/viewmodel_tests/account_view_model_test.dart

…ting user

* - added account details page - created basic ui - new package for toggle button and created component * - Updated edit account details page - added all text fiels and buttons - removed toggle button from external package * - worked out padding on account details page - added delete text button on account details page * - latest update on profile page * A few profile page fixes * name now saves on profile page * Added dob to account details * Updates to dob * Added location to profile page and remote config * Fix for http in webview issue * Added organisations to home page * Feature/delete account (#142) * Create button action and methods in model and auth confirming methods were fired on click * Logout tested, methods triggering * Log deleting account with analytics * Testing deleting with staging api * Implement confirmation modal confirming deletion * Uncomment all methods and remove testing prints - code ready * Added basic viewmodel test * Added test workflow * Workflow fix * Updated action to run on any pr * Changed flutter version * Remove java and flutter version * Test for failed save * Broke the tests * Assigining new user to _currentUser; Saving user to Shared Preferences * Add appropriate console logs to confirm logging in and sources of getting user * Correct login method to call updateUser instead of directly saving prefs * Remove user from SharedPrefs on account deletion * Minor methods order changed * Display error message if returned false from auth * Error handling with different messages * Model test for account deletion * Unsure * save and delete tests * Started some tests that will be finished later Co-authored-by: jelgar <[email protected]> * Commit from GitHub Actions (Flutter tests) Co-authored-by: tristanclarke <[email protected]> Co-authored-by: Piotr Stanny <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

piotrstanny added 6 commits December 9, 2020 12:15

Create button action and methods in model and auth confirming methods…

d31364a

… were fired on click

Logout tested, methods triggering

56627fe

Log deleting account with analytics

083d881

Testing deleting with staging api

f20c4f1

Implement confirmation modal confirming deletion

6f07a7a

Uncomment all methods and remove testing prints - code ready

2552901

piotrstanny requested a review from JElgar December 11, 2020 14:39

JElgar requested changes Dec 12, 2020

View reviewed changes

JElgar requested changes Dec 13, 2020

View reviewed changes

JElgar added 9 commits December 15, 2020 18:52

Merge branch 'dev' into feature/delete_account

b4f398d

Merge branch 'feature/more_profile_page' into feature/delete_account

a0ffd25

Added basic viewmodel test

751ef46

Added test workflow

f69ee08

Workflow fix

9484e8a

Updated action to run on any pr

1967fcc

Changed flutter version

8932d37

Remove java and flutter version

6d15556

Test for failed save

32ef8c7

JElgar linked an issue Dec 16, 2020 that may be closed by this pull request

"Delete my account" feature on the app #83

Open

JElgar reviewed Dec 30, 2020

View reviewed changes

test/viewmodel_tests/account_view_model_test.dart Outdated Show resolved Hide resolved

JElgar and others added 9 commits January 30, 2021 10:26

Broke the tests

fafae7e

Assigining new user to _currentUser; Saving user to Shared Preferences

b4cfcff

Add appropriate console logs to confirm logging in and sources of get…

3307225

…ting user

Correct login method to call updateUser instead of directly saving prefs

d65a85e

Remove user from SharedPrefs on account deletion

d0eb600

Minor methods order changed

8688547

Display error message if returned false from auth

0ac390b

Error handling with different messages

e6184e2

Model test for account deletion

a576092

JElgar added 3 commits April 11, 2021 10:11

Unsure

91b2568

save and delete tests

8e2728b

Started some tests that will be finished later

06c66c7

JElgar merged commit 0f4b619 into feature/more_profile_page May 21, 2021

JElgar deleted the feature/delete_account branch May 21, 2021 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/delete account #142

Feature/delete account #142

piotrstanny commented Dec 11, 2020 •

edited by JElgar

Loading

JElgar left a comment

JElgar Dec 11, 2020

JElgar Dec 11, 2020

JElgar Dec 12, 2020

JElgar Dec 12, 2020

JElgar left a comment

piotrstanny commented Dec 15, 2020

-    await _authenticationService.deleteUserAccount();
+    if (!await _authenticationService.deleteUserAccount()) {
+        _dialog_service -> something when wrong message
+    } else {
+        await _analyticsService.logUserAccountDeleted();
+        logout();
+    }

Feature/delete account #142

Feature/delete account #142

Conversation

piotrstanny commented Dec 11, 2020 • edited by JElgar Loading

Description

Checklist:

Creator

Reviewer

After pull

JElgar left a comment

Choose a reason for hiding this comment

JElgar Dec 11, 2020

Choose a reason for hiding this comment

JElgar Dec 11, 2020

Choose a reason for hiding this comment

JElgar Dec 12, 2020

Choose a reason for hiding this comment

JElgar Dec 12, 2020

Choose a reason for hiding this comment

JElgar left a comment

Choose a reason for hiding this comment

piotrstanny commented Dec 15, 2020

piotrstanny commented Dec 11, 2020 •

edited by JElgar

Loading