Operator panics when no TLS in route BZ 2321196

[alphaprinz]

Environment info

• NooBaa Operator Version: Probably introduced with 9975b2b

Actual behavior

1. Stack trace is
   2024-10-22T17:28:50.118458720Z time="2024-10-22T17:28:50Z" level=info msg="ReconcileObject: Done - unchanged Service noobaa-mgmt " sys=openshift-storage/noobaa
   2024-10-22T17:28:50.143071693Z time="2024-10-22T17:28:50Z" level=info msg="ReconcileObject: Done - unchanged StatefulSet noobaa-core " sys=openshift-storage/noobaa
   2024-10-22T17:28:50.244541921Z time="2024-10-22T17:28:50Z" level=info msg="ReconcileObject: Done - unchanged Route noobaa-mgmt " sys=openshift-storage/noobaa

2024-10-22T17:28:50.244861186Z time="2024-10-22T17:28:50Z" level=info msg="ReconcileObject: Done - unchanged Service s3 " sys=openshift-storage/noobaa
2024-10-22T17:28:50.247070656Z panic: runtime error: invalid memory address or nil pointer dereference [recovered]
2024-10-22T17:28:50.247070656Z panic: runtime error: invalid memory address or nil pointer dereference
2024-10-22T17:28:50.247070656Z [signal SIGSEGV: segmentation violation code=0x1 addr=0x58 pc=0x1ed6bed]
2024-10-22T17:28:50.247102309Z
2024-10-22T17:28:50.247102309Z goroutine 2854 [running]:
2024-10-22T17:28:50.247102309Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
2024-10-22T17:28:50.247121937Z /remote-source/deps/gomod/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116 +0x1e5
2024-10-22T17:28:50.247138575Z panic({0x22db340?, 0x4171860?})
2024-10-22T17:28:50.247154783Z /usr/lib/golang/src/runtime/panic.go:914 +0x21f
2024-10-22T17:28:50.247185850Z github.com/noobaa/noobaa-operator/v5/pkg/system.(*Reconciler).SetDesiredRouteS3(...)
2024-10-22T17:28:50.247185850Z /remote-source/app/pkg/system/phase2_creating.go:187
2024-10-22T17:28:50.247202853Z github.com/noobaa/noobaa-operator/v5/pkg/system.(*Reconciler).reconcileObjectAndGetResult.func1()
2024-10-22T17:28:50.247202853Z /remote-source/app/pkg/system/reconciler.go:635 +0x18

Expected behavior

1. Operator should not panic.

Steps to reproduce

1. Define a route without TLS

More information - Screenshots / Logs / Other output

More details in https://bugzilla.redhat.com/show_bug.cgi?id=2321196