lib: handle Float16Array in node:v8 serdes

[bartlomieju]

This commit adds support for Float16Array in node:v8 serde APIs.

While Float16Array is not available as a global yet (pending stabilization in V8),
I "reserved" the next available index for serde purposes so other runtimes, like Deno,
that already support Float16Array, can support it in node:v8 serde APIs
in a future compatible way.

Closes #55574.

[bartlomieju]

CC @bnoordhuis @targos

[cjihrig]

The linter is failing (make lint-js).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.95%. Comparing base (3511c5c) to head (b50cbcd).
Report is 29 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55996   +/-   ##
=======================================
  Coverage   87.95%   87.95%           
=======================================
  Files         656      656           
  Lines      188304   188376   +72     
  Branches    35972    35980    +8     
=======================================
+ Hits       165624   165691   +67     
+ Misses      15853    15850    -3     
- Partials     6827     6835    +8     

Files with missing lines	Coverage Δ
lib/v8.js	98.65% <100.00%> (+0.01%)	⬆️

... and 32 files with indirect coverage changes

[LiviaMedeiros]

Wouldn't using undefined reference throw if there's actual [object Float16Array] polyfilled in user space?

const { serializeError, deserializeError } = require('internal/error_serdes');
Object.defineProperty(Float32Array.prototype, Symbol.toStringTag, { get() { return 'Float16Array'; } });
console.log(deserializeError(serializeError(new Error('test', { cause: new Float32Array(9) }))));

Suggested change

	if (index === 13) return Float16Array;
	if (index === 13) return typeof Float16Array !== 'undefined' ? Float16Array : undefined;

[bnoordhuis]

if there's actual [object Float16Array] polyfilled in user space?

I don't think that's much of a concern because you can't reasonably polyfill it in JS land. Speaking as someone who implemented Float16Array in a JS engine.

[aduh95]

We should destructure it from globalThis – it would be good to add a lint rule for it similar to

node/lib/eslint.config_partial.mjs

Lines 208 to 213 in c42d846

	// ShadowRealm is not available in primordials because it can be
	// disabled with --no-harmony-shadow-realm CLI flag.
	{
	name: 'ShadowRealm',
	message: 'Use `const { ShadowRealm } = globalThis;` instead of the global.',
	},

[aduh95]

@bartlomieju wdyt about my suggestion?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63767/