Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update zlib to 1.3.0.1-motley-82a5fec #55980

Merged
merged 1 commit into from
Nov 29, 2024
Merged

deps: update zlib to 1.3.0.1-motley-82a5fec #55980

merged 1 commit into from
Nov 29, 2024
+6 −5

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of zlib to 1.3.0.1-motley-82a5fec.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. zlib Issues and PRs related to the zlib subsystem. labels Nov 24, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 24, 2024
@lpinca
Copy link
Member

lpinca commented Nov 24, 2024

I would skip this, it doesn't change anything used by Node.js.

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (e92499c) to head (6065dd8).
Report is 41 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55980   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         653      653           
  Lines      188091   188091           
  Branches    35941    35945    +4     
=======================================
+ Hits       165516   165521    +5     
+ Misses      15751    15732   -19     
- Partials     6824     6838   +14

see 30 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63697/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63703/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4efb7ae into main Nov 29, 2024
76 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 4efb7ae

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-zlib branch November 29, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @lpinca @RafaelGSS @marco-ippolito