You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Override __eq__ of Panel cause problem. Assume panel_a is __eq__ to panel_b and panel_b is __eq__ to panel_c, but it is may not true that panel_a is __eq__ to panel_c.
If panel_a, panel_b, panel_c are in panels array(order a b c) and we remove it with.order panel_b, panel_c, panel_a, then panel_a, panel_b will be remove in order, and error will occur when try to remove pane_a because panel_c is left in panels array. This may happens in merge_panes in page.py
Maybe we should avoid override default __eq__ (lt) etc and use explicit func with similartop_left etc
The text was updated successfully, but these errors were encountered:
Override
__eq__
ofPanel
cause problem. Assume panel_a is__eq__
topanel_b
andpanel_b
is__eq__
topanel_c
, but it is may not true thatpanel_a
is__eq__
topanel_c
.If
panel_a
,panel_b
,panel_c
are in panels array(order a b c) and we remove it with.orderpanel_b
,panel_c
,panel_a
, thenpanel_a
,panel_b
will be remove in order, and error will occur when try to removepane_a
becausepanel_c
is left in panels array. This may happens inmerge_panes
in page.pyMaybe we should avoid override default
__eq__
(lt) etc and use explicit func withsimilar
top_left
etcThe text was updated successfully, but these errors were encountered: