Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgio #61

Open
Tracked by #49
Hebilicious opened this issue Jul 5, 2023 · 1 comment · May be fixed by #77
Open
Tracked by #49

edgio #61

Hebilicious opened this issue Jul 5, 2023 · 1 comment · May be fixed by #77

Comments

@Hebilicious
Copy link
Collaborator

No description provided.

@Hebilicious Hebilicious added the ci label Jul 5, 2023
This was referenced Jul 8, 2023
@Hebilicious
Copy link
Collaborator Author

Hebilicious commented Jul 8, 2023

After investigating this preset, I found out it no longer works.
It looks like it's no longer possible to deploy with the cli v6, and the cli v7 is required with new projects.

v6

npx edgio deploy --team=UnJs --site=nitro-deployment --token=$EDGIO_DEPLOY_TOKEN     
WARNING: edgio platform serverless runtime supports only Node.js v16. Your current version is v20.2.0.
If your backend code (SSR, Api endpoints, etc.) uses Node.js v20.2.0 features it may not work as expected once deployed on the edgio platform.
🔑 Incorrect apiKey.


Deploy token is invalid or disabled!

v7

npx edgio deploy --property=nitro-deployment --token=$EDGIO_DEPLOY_TOKEN

WARNING: edgio platform serverless runtime supports only Node.js v16. Your current version is v20.2.0.
If your backend code (SSR, Api endpoints, etc.) uses Node.js v20.2.0 features it may not work as expected once deployed on the edgio platform.
🔑 Logged in as "test2" deploy token of site "nitro-deployment".

📋 Deploying to:
> Team: unjs
> Property: nitro-deployment
> branch: edgio
> Environment: default
> Edgio version: 7.0.24
> Commit URL: https://github.com/unjs/nitro-deploys/commit/34bf6dbc08c7fc07211f7525abc1e0b06e0b9b1b
> Deployment #1

🛠️  Building your app for deployment on Edgio
> Bundling router... done.

TypeError: router.fallback is not a function

The v7 upgrade is a breaking change and breaks our current Nitro preset (the fallback() method is no longer available). I assume this provider is unpopular so no-one noticed...

This preset will need to be refactored with v7 in mind : https://docs.edg.io/guides/v7/sites_frameworks/getting_started/nuxt3
It looks like we can/should use their undocumented nitropack connector.

This should work for Nitro standalone, however it won't probably won't for Nuxt as there is a separated connector.

I don't have a way to test v6 apps and the old preset, but we need to either update it to v7 or create a new one and warn that the old one doesn't work for new apps anymore.

For the preset implementation, if we follow their instructions we can just run npx edgio init && npx edgio build in the preset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant