Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential dependency hell with assistant and html2text #10404

Open
ChristophWurst opened this issue Nov 25, 2024 · 2 comments
Open

Potential dependency hell with assistant and html2text #10404

ChristophWurst opened this issue Nov 25, 2024 · 2 comments

Comments

@ChristophWurst
Copy link
Member

Steps to reproduce

  1. Install Mail
  2. Install Assistant
  3. ???

Expected behavior

No dependency collision

Actual behavior

https://github.com/nextcloud/assistant/blob/38c12770be3a2c29c0c022323b407aa630dab279/composer.json#L17

"hamza221/html2text": "^1.0",

^ we use a patched one. If the assistant html2text is loaded first we'll have a problem in Mail.

Mail app version

No response

Nextcloud version

No response

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Nextcloud memory caching

No response

Web server

None

Database

None

Additional info

cc @julien-nc @hamza221

@hamza221
Copy link
Contributor

we can retry our luck with mtibben/html2text#116
and switch back to the main package

@ChristophWurst
Copy link
Member Author

That is good. The underlying problem of discrepancies between the html2text used/shipped by the two apps will still not be solved.

This seems to be ok right now, hence "Potential". But we have had other cases of dependencies that were used in 2+ apps, upgrade in one and caused an issue in the other(s).

https://docs.nextcloud.com/server/latest/developer_manual/app_development/dependency_management.html#dependency-hell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants