Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: A database of the healthy human spinal cord morphometry in the PAM50 template space #16

Closed
roboneuro opened this issue Sep 7, 2023 · 43 comments

Comments

@roboneuro
Copy link

roboneuro commented Sep 7, 2023

Submitting author: @valosekj (Jan Valošek)
Repository: https://github.com/valosekj/PAM50-normalized-metrics-paper
Branch with paper.md (empty if default branch): main
Version: r20230904
Editor: @agahkarakuzu
Reviewers: @mathieuboudreau
Managing EiC: Agah Karakuzu

Status

status

Status badge code:

HTML: <a href="https://neurolibre.org/papers/764a9031ba7a9108dc07a0da1c09dfbb"><img src="https://neurolibre.org/papers/764a9031ba7a9108dc07a0da1c09dfbb/status.svg"></a>
Markdown: [![status](https://neurolibre.org/papers/764a9031ba7a9108dc07a0da1c09dfbb/status.svg)](https://neurolibre.org/papers/764a9031ba7a9108dc07a0da1c09dfbb)

Author instructions

Thanks for submitting your paper to NeuroLibre @valosekj. Currently, there isn't a NeuroLibre editor assigned to your paper.

The AEiC suggestion for the handling editor is @agahkarakuzu.

@valosekj if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for NeuroLibre and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The NeuroLibre submission bot @roboneuro is here to help you find and assign reviewers and start the main review. To find out what @roboneuro can do for you type:

@roboneuro commands
@agahkarakuzu
Copy link
Member

@roboneuro generate pdf

@agahkarakuzu
Copy link
Member

@roboneuro commands

@roboneuro
Copy link
Author

Hello @agahkarakuzu, here are the things you can ask me to do:


# List all available commands
@roboneuro commands

# Add to this issue's reviewers list
@roboneuro add @username as reviewer

# Remove from this issue's reviewers list
@roboneuro remove @username from reviewers

# Get a list of all editors's GitHub handles
@roboneuro list editors

# Assign a user as the editor of this submission
@roboneuro assign @username as editor

# Remove the editor assigned to this submission
@roboneuro remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@roboneuro remind @reviewer in 2 weeks

# Check the references of the PDF for missing DOIs
@roboneuro check references

# Perform checks on the repository
@roboneuro check repository

# Adds a checklist for the reviewer using this command
@roboneuro generate my checklist

# Set a value for version
@roboneuro set v1.0.0 as version

# Set a value for branch
@roboneuro set neurolibre-paper as branch

# Set a value for repository
@roboneuro set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@roboneuro set set 10.5281/zenodo.6861996 as archive

# Set a value for the (data/book/repository/docker) archive DOI.
@roboneuro set 10.5281/zenodo.6861996 as data archive

# Set executable book URI for the preprint.
@roboneuro set book uri

# Mention the EiCs for the correct track
@roboneuro ping track-eic

# Reject paper
@roboneuro reject

# Withdraw paper
@roboneuro withdraw

# Invite an editor to edit a submission (sending them an email)
@roboneuro invite @(.*) as editor

# Generates the pdf paper
@roboneuro generate pdf

# Recommends the submission for acceptance
@roboneuro recommend-accept

# Accept and publish the paper
@roboneuro accept

# Update data on an accepted/published paper
@roboneuro reaccept

# Generates a LaTeX preprint file
@roboneuro generate preprint

# Flag submission with questionable scope
@roboneuro query scope

# Get a link to the complete list of reviewers
@roboneuro list reviewers

# Creates a post-review checklist with editor and authors tasks
@roboneuro create post-review checklist

# Open the review issue
@roboneuro start review

# Check the status of the NeuroLibre preview server.
@roboneuro preview server status

# Check the status of the NeuroLibre preprint (production) server.
@roboneuro preprint server status

# Build a NeuroLibre reproducible preprint for technical screening.
@roboneuro build book

# After screening, build book from the forked reository.
@roboneuro production build book

# Transfer data from preview to the preprint (production) server.
@roboneuro production sync data

# Transfer the final preprint (forked repo) to the preprint (production) server (DOI URL).
@roboneuro production sync book

# Start the production process by forking repository and configuring it.
@roboneuro production start

# Creates Zenodo deposits (a.k.a buckets) for archiving reproducibility assets.
@roboneuro zenodo create buckets

# Status check for the archival of the reproducibility assets.
@roboneuro zenodo status

# Copy summary PDF from the preprints repository to the NeuroLibre production server.
@roboneuro production sync pdf

# Upload the latest Jupyter Book to Zenodo for archival.
@roboneuro zenodo upload book

# Upload the latest version of the book repository to Zenodo for archival.
@roboneuro zenodo upload repository

# Upload the latest version of the docker image to Zenodo for archival.
@roboneuro zenodo upload docker

# Publish reproducibility assets on Zenodo. Sets DOIs if successful.
@roboneuro zenodo publish

@agahkarakuzu
Copy link
Member

@roboneuro preview server status

@roboneuro
Copy link
Author

Can't perform this without reviewers

@roboneuro
Copy link
Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@agahkarakuzu
Copy link
Member

@roboneuro add @mathieuboudreau as reviewer

@roboneuro
Copy link
Author

Can't add reviewers: There is no editor assigned yet

@agahkarakuzu
Copy link
Member

@roboneuro assign @agahkarakuzu as editor

@roboneuro
Copy link
Author

Assigned! @agahkarakuzu is now the editor

@agahkarakuzu
Copy link
Member

@roboneuro add @mathieuboudreau as reviewer

@roboneuro
Copy link
Author

@mathieuboudreau added to the reviewers list!

@agahkarakuzu
Copy link
Member

@roboneuro preview server status

@roboneuro
Copy link
Author

🟢 NeuroLibre server is active (running).
🍀 Ready to accept requests from Issue #16
🔗 URL: https://preview.neurolibre.org

@agahkarakuzu
Copy link
Member

@roboneuro build book

@roboneuro
Copy link
Author

Requested branch/SHA does not exist for https://github.com/valosekj/PAM50-normalized-metrics-paper/

@agahkarakuzu
Copy link
Member

@roboneuro build book

@roboneuro
Copy link
Author

roboneuro commented Sep 7, 2023

🟢 Successfully built

Status: Success 78a047ee
Last updated: 2023-09-07 06:49:45 PDT

ℹ️ See details
The next comment will forward the logs

@roboneuro
Copy link
Author

roboneuro commented Sep 7, 2023

https://preview.neurolibre.org/book-artifacts/valosekj/github.com/PAM50-normalized-metrics-paper/786f9a3aa69365b57f42174356bb9918951542db/_build/_page/index/singlehtml/

@agahkarakuzu
Copy link
Member

agahkarakuzu commented Sep 7, 2023

@valosekj thank you so much for the submission!

I started some tasks to check the status of the PDF build (succeeds, there's an issue with the template on our end, I'll revert the funny author names section) as well as the jupyter book build (in progress).

I see that the GitHub action to build jupyter book is never triggered, I guess because you have not pushed to main since you added main.yml.

Also, I deleted the trailing / from the repository URL you provided during submission. I'll add a check to the submission system to deal with that automatically in future submissions neurolibre/neurolibre-neo#10, thanks!

The book is built and served in the link above, but looks like figures etc. are not rendered, yet these are not captured as errors. I'll look into it and let you know.

@agahkarakuzu
Copy link
Member

agahkarakuzu commented Sep 7, 2023

@valosekj

OK, looks like the data location and the code are functional! I was able to generate tables and figures on Binder. To render plotly outputs in Jupyter Book, you need something like the following

from IPython.display import display, HTML
from plotly.offline import plot

my_table = table_demographic_characteristics(path_csv)
plot(my_table, filename = 'table1.html')
display(HTML('table1.html'))

I guess the function table_demographic_characteristics is not returning a plotly object, but the same pattern should work for create_subplot(df).

@valosekj
Copy link

valosekj commented Sep 8, 2023

To render plotly outputs in Jupyter Book, you need something like the following

from IPython.display import display, HTML
from plotly.offline import plot

my_table = table_demographic_characteristics(path_csv)
plot(my_table, filename = 'table1.html')
display(HTML('table1.html'))

Good catch! Thanks! I fixed this in spinalcordtoolbox/PAM50-normalized-metrics@192d0af and valosekj/PAM50-normalized-metrics-paper@e62f9ea.

@valosekj
Copy link

valosekj commented Sep 8, 2023

I see that the GitHub action to build jupyter book is never triggered, I guess because you have not pushed to main since you added main.yml.

Okay, after the last push to main, the GitHub action has been triggered but failed on the permission issue during cloning of the https://github.com/valosekj/PAM50-normalized-metrics-paper.git/ repo, which is strange because the repo is public and the link works for me.

@valosekj
Copy link

valosekj commented Sep 8, 2023

Also, I do not know if this is relevant, but I specified a particular release (r20230904) during the submission, which is no longer applicable after the recent commit.

@valosekj
Copy link

Do you know how to include chapter headings in the left sidebar? Currently, only Abstract is included, but I use # also for all other headings in my content/index.ipynb.

image

@agahkarakuzu
Copy link
Member

@roboneuro generate pdf

@roboneuro
Copy link
Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@agahkarakuzu
Copy link
Member

@valosekj in single page format we would like to get rid of the sidebar as in https://rrsg2020.github.io/paper/.

To do that, it takes a tiny modification. IIRC:

only_build_toc_files: true

Pinging @mathieuboudreau to confirm.

Also in the summary PDF, looks like there are some WIP sections, can you please go through them?

@agahkarakuzu
Copy link
Member

@roboneuro generate pdf

@roboneuro
Copy link
Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@valosekj
Copy link

@valosekj in single page format we would like to get rid of the sidebar as in https://rrsg2020.github.io/paper/.

To do that, it takes a tiny modification. IIRC:

only_build_toc_files: true

Okay! Done in valosekj/PAM50-normalized-metrics-paper@d5459f8.

Also in the summary PDF, looks like there are some WIP sections, can you please go through them?

Thanks for pointing this out! The WIP sections (TODOs) are about adding a link to the interactive preprint to paper.md and content/index.ipynb. Is there already a permanent link that won't change in the future that I could use?

@agahkarakuzu
Copy link
Member

@roboneuro build book

@roboneuro
Copy link
Author

roboneuro commented Sep 28, 2023

🟢 Successfully built

Status: Success a22a27a7
Last updated: 2023-09-28 10:29:32 PDT

ℹ️ See details
The next comment will forward the logs

@agahkarakuzu
Copy link
Member

Thanks for pointing this out! The WIP sections (TODOs) are about adding a link to the interactive preprint to paper.md and content/index.ipynb. Is there already a permanent link that won't change in the future that I could use?

@valosekj The PDF template itself has already a link to the reproducible preprint (on the left column): https://github.com/neurolibre/preprints/blob/neurolibre.00016/neurolibre.00016/10.55458.neurolibre.00016.pdf

They will resolve into DOI-formatted proper URLs upon publishing. So no need to duplicate it unless you want to. In that case the URL will be: https://preprint.neurolibre.org/10.55458/neurolibre.00016

@agahkarakuzu
Copy link
Member

agahkarakuzu commented Sep 28, 2023

@valosekj the book build succeeds and the interactive figures are now rendered, thank you!!

Can you tag the code cells as described below so that they become collapsable in the jupyter book:

https://jupyterbook.org/en/stable/content/metadata.html#jupyter-cell-tags

Also, can you change the jupyter-book requirement version to jupyter-book==0.13.0 and I'll see if it gets rid of that sidebar.

@valosekj
Copy link

Thanks for pointing this out! The WIP sections (TODOs) are about adding a link to the interactive preprint to paper.md and content/index.ipynb. Is there already a permanent link that won't change in the future that I could use?

@valosekj The PDF template itself has already a link to the reproducible preprint (on the left column): https://github.com/neurolibre/preprints/blob/neurolibre.00016/neurolibre.00016/10.55458.neurolibre.00016.pdf

They will resolve into DOI-formatted proper URLs upon publishing. So no need to duplicate it unless you want to. In that case the URL will be: https://preprint.neurolibre.org/10.55458/neurolibre.00016

Okay! Resolved in valosekj/PAM50-normalized-metrics-paper@818b217.

Can you tag the code cells as described below so that they become collapsable in the jupyter book:

Done in valosekj/PAM50-normalized-metrics-paper@c24057c.

Also, can you change the jupyter-book requirement version to jupyter-book==0.13.0 and I'll see if it gets rid of that sidebar.

Sure! Done in valosekj/PAM50-normalized-metrics-paper@4094a08.

@agahkarakuzu
Copy link
Member

@roboneuro build book

@roboneuro
Copy link
Author

roboneuro commented Sep 28, 2023

🟢 Successfully built

Status: Success 0ae2896b
Last updated: 2023-09-28 13:05:44 PDT

ℹ️ See details
The next comment will forward the logs

@agahkarakuzu
Copy link
Member

Perfect! Now I'll move this to actual review.

@agahkarakuzu
Copy link
Member

@roboneuro start review

@roboneuro
Copy link
Author

OK, I've started the review over in openjournals/joss-reviews#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants