feat(issue-38): Add .env support #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.go
Outdated
| @@ -15,6 +17,9 @@ var resources embed.FS | |||
| func main() { | |||
| logger.PrintInfo("nearForm: k8s kurated addons CLI") | |||
|
|
|||
| // load .env file | |||
| godotenv.Load(".env") | |||
There was a problem hiding this comment.
It would be nice for the user to be able to specify the file, a KKA_CONFIG_FILE environment variable would be more than enough.
There was a problem hiding this comment.
If the configuration file doesn't exist it might be worth it to crash the program to avoid building things with the wrong parameters.
|
It would also be go to write a small test for the cli.go to test that environment variables are loaded correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38