Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vitest workerd configuration #55

Merged
merged 5 commits into from
Jul 7, 2024

Conversation

NachoVazquez
Copy link
Contributor

@NachoVazquez NachoVazquez commented Jul 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current configuration and generated files for tests are not working.

What is the new behavior?

We have replicated a working configuration in a clean project and made here the proper changes to fix the tests.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

nx-cloud bot commented Jul 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6b7f0f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@NachoVazquez NachoVazquez merged commit 02ef07f into main Jul 7, 2024
5 checks passed
@NachoVazquez NachoVazquez deleted the fix/vitest-workerd-configuration branch July 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants