Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/47/configure vite and workerd for tests #53

Merged
merged 5 commits into from
Jul 6, 2024

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We are using the unstable workers api for our tests and e2e tests

Fixes: #47

What is the new behavior?

  • Now all tests are generated using the experimental workerd + Vitests test interface
  • We have added an example of integration tests

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

nx-cloud bot commented Jul 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 58bdb6a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

cloudflare-workers-and-pages bot commented Jul 6, 2024

Deploying nx-cloudflare-next-example with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58bdb6a
Status: ✅  Deploy successful!
Preview URL: https://4fb406ac.oss-9xl.pages.dev
Branch Preview URL: https://feat-47-configure-vite-and-w.oss-9xl.pages.dev

View logs

@NachoVazquez NachoVazquez merged commit 63b933a into main Jul 6, 2024
5 checks passed
@NachoVazquez NachoVazquez deleted the feat/47/configure-vite-and-workerd-for-tests branch July 6, 2024 23:19
NachoVazquez pushed a commit that referenced this pull request Jul 7, 2024
* feat: configure vitest-pool-workers
* fix: remove unneded test script
* feat: add needed vitest configuration
* feat: add template for new unit tests and integration tests format
* fix: nrwl/nx#23435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Vitest on templates to support Workerd
2 participants