Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summarize-multiqc-pair doesn't give information for each read pair separately anymore. #102

Open
simonleandergrimm opened this issue Nov 19, 2024 · 1 comment
Assignees

Comments

@simonleandergrimm
Copy link
Collaborator

simonleandergrimm commented Nov 19, 2024

@willbradshaw I didn't see an issue for this, though you noted it in the code itself:

# NB: Current paired version can't distinguish or annotate forward vs reverse reads in these plots.
# TODO: Restore this functionality (will require workflow restructuring).

This might not matter much for Illumina data, but our current test dataset is AVITI sequencing, where the forward reads have far better quality than the reverse reads, leading plots that do not take into account read quality to look very bad:
image
image

# NB: Current paired version can't distinguish or annotate forward vs reverse reads in these plots.

@simonleandergrimm simonleandergrimm added the bug Something isn't working label Nov 19, 2024
@simonleandergrimm simonleandergrimm self-assigned this Nov 19, 2024
@willbradshaw
Copy link
Contributor

In the few cases where it matters, it should be possible for the user to distinguish forward from reverse reads based on the information in the output; e.g. based on the file column in the quality/adapter QC data.

I'm not sure what you mean by "look very bad", but if you mean the zigzag effect due to having multiple rows in the same plotting group, you can fix this in ggplot with group=file (I'm not sure what the equivalent for matplotlib is but it very likely exists).

@willbradshaw willbradshaw removed the bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants