Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Overflow on email smtp setup page title - Mobile view #13

Open
muzammildafedar opened this issue Sep 28, 2024 · 11 comments
Open

UI Overflow on email smtp setup page title - Mobile view #13

muzammildafedar opened this issue Sep 28, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags!

Comments

@muzammildafedar
Copy link
Owner

Description:
The above Instructions button is overlapping with the header text on the "Setup Your Email Using SMTP" page, causing a visual issue where the right side of the button extends beyond the intended area.

Steps to Reproduce:
Go to the Email Setup page.
Observe title overflow.

Expected Behavior:
The Instructions title should be properly aligned or flexible size and not overlap with any part of the header text.

Actual Behavior:
There is visible text showing a pixel overflow warning on the right side.

Suggested Fix:
Adjust the size of the title to ensure it is positioned correctly beneath the header text.

Screenshot 2024-09-28 at 10 09 25 AM
@muzammildafedar muzammildafedar added good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! labels Sep 28, 2024
@PartishtaP
Copy link

Heeyyy!!
Please assign me this.
I would like to work on it

@muzammildafedar
Copy link
Owner Author

muzammildafedar commented Sep 28, 2024

Heeyyy!! Please assign me this. I would like to work on it

Don't forget to fork the repository before starting. @PartishtaP Feel free to go ahead and take on the issue. Let me know if you need any help or clarification. Looking forward to your contributions!

@PartishtaP
Copy link

Heyy!!
can you please tell where is the code for the email set up page, like in which file.

@muzammildafedar
Copy link
Owner Author

muzammildafedar commented Sep 28, 2024

Heyy!! can you please tell where is the code for the email set up page, like in which file.

The SMTP page is located in lib/widgets/smtp_page.dart, where we use a custom widget called CategoryBox that includes a title prefix for all pages. In this widget, the title parameter is utilized between lines 53 and 56. Currently, AppTextStyle is defined, but you need to define another AppTextStyle specifically for mobile, which will reduce the font size. Additionally, you'll need to add a condition to adjust the font size based on whether the view is on mobile or desktop. See the example below:

Text(
  title,
  style: Responsive.isMobile(context) ? AppTextStyles.heading1BlackMobile : AppTextStyles.heading1Black,
),

Make sure to import:

import 'package:udayah/responsive.dart';

@thedevyash
Copy link

is this issue still open and if @PartishtaP not working on this anymore, can i work on this?
@muzammildafedar

@muzammildafedar
Copy link
Owner Author

Yes, This issue still open. Feel free to go ahead and take on the issue.

is this issue still open and if @PartishtaP not working on this anymore, can i work on this? @muzammildafedar

@muzammildafedar
Copy link
Owner Author

@thedevyash are you still working on this issue?

@may-tas
Copy link

may-tas commented Oct 6, 2024

I would like to work on this issue if its still open.

@Amitkumarkoli
Copy link

is this still open?? I want to work on this.

@muzammildafedar
Copy link
Owner Author

@thedevyash how's your progress on this? FYI, I'll need to un-assign you soon if I don't hear back

@tanayduddalwar
Copy link

@muzammildafedar please assign me this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags!
Projects
None yet
Development

No branches or pull requests

6 participants