Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: sending data in chunks #55

Open
qbolsee opened this issue May 9, 2020 · 0 comments
Open

Enhancement: sending data in chunks #55

qbolsee opened this issue May 9, 2020 · 0 comments

Comments

@qbolsee
Copy link

qbolsee commented May 9, 2020

Hi,

When using pyupdi to flash a ATtiny1614 using a SAMD11C, I experienced some very specific bug forcing me to send data in chunks smaller than 64 bytes. I documented the issue here:
http://fabacademy.org/2020/labs/ulb/students/quentin-bolsee/projects/d11c_ftdi-updi/#arduino-core

I propose the following patch to handle this kind of issue:
chunk_patch.txt

Basically, the send() function in physical.py is modified to slice up data in chunks of a given max size. I think it's reasonable to use chunks when waiting for the echo, otherwise you can easily fill up some buffers on the USB serial, leading to strange behaviors.

@qbolsee qbolsee changed the title Limitted chunk size when sending Enhancement: sending data in chunks May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant