Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running launch file in examples/move_group_interface, there are two node with same name /rivz2 #991

Open
MoonBunnyZZZ opened this issue Nov 21, 2024 · 1 comment

Comments

@MoonBunnyZZZ
Copy link

MoonBunnyZZZ commented Nov 21, 2024

Ubuntu: 22.04
ROS2: humble

code version
repositories:
launch_param_builder:
type: git
url: https://github.com/PickNikRobotics/launch_param_builder
version: main
moveit2:
type: git
url: https://github.com/ros-planning/moveit2
version: humble
moveit_resources:
type: git
url: https://github.com/ros-planning/moveit_resources
version: humble
moveit_task_constructor:
type: git
url: https://github.com/ros-planning/moveit_task_constructor.git
version: humble
moveit_visual_tools:
type: git
url: https://github.com/ros-planning/moveit_visual_tools
version: ros2
rosparam_shortcuts:
type: git
url: https://github.com/PickNikRobotics/rosparam_shortcuts
version: ros2
srdfdom:
type: git
url: https://github.com/ros-planning/srdfdom.git
version: ros2

After colcon building, run ' ros2 launch moveit2_tutorials move_group.launch.py'.There are two rviz2 node with same name.
source install/setup.bash && ros2 node list

WARNING: Be aware that are nodes in the graph that share an exact name, this can have unintended side effects.
/controller_manager
/interactive_marker_display_104851965511536
/joint_state_broadcaster
/move_group
/move_group_private_102409399057152
/moveit_simple_controller_manager
/panda_arm_controller
/panda_hand_controller
/robot_state_publisher
/rviz2
/rviz2
/rviz2_private_133986940619904
/rviz2_private_133987075316320
/static_transform_publisher
/transform_listener_impl_5d240bdc9c10
/transform_listener_impl_5f5cbfe8a610
/transform_listener_impl_5f5cbff94a90
/transform_listener_impl_79dc44167fd0
/transform_listener_impl_79dc4c0145e0

@sea-bass
Copy link
Contributor

sea-bass commented Nov 23, 2024

I just looked into this and turns out RViz starts up a handful of nodes with different names... but if you change the name in the launch file, it names them all the same: ros2/rviz#671 (comment)

It so turns out that the RViz nodes set up in the launch files are like this:

    rviz_node = Node(
        package="rviz2",
        executable="rviz2",
        name="rviz2",  # <-- THIS IS THE ISSUE
        output="log",
        arguments=["-d", rviz_config_file],
        parameters=[
            moveit_config.robot_description,
            moveit_config.robot_description_semantic,
            moveit_config.robot_description_kinematics,
            moveit_config.planning_pipelines,
            moveit_config.joint_limits,
        ],
    )

If you comment out the line shared above, it should all look good. I tested this on my end just now.

We should fix this in this repository by simply omitting the name="blah" remapping in all RViz launches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants