Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect global gitignores #161

Open
nicktimko opened this issue Sep 16, 2024 · 2 comments
Open

feat: respect global gitignores #161

nicktimko opened this issue Sep 16, 2024 · 2 comments
Labels

Comments

@nicktimko
Copy link

On my workstations, I'll usually have .DS_Store in a Mac's global Git ignores, or desktop.ini for Windows. That global gitignore is found via the core.excludesfile Git config.

Don't know how it should be implemented, but if I run git config --get[-all] core.excludesfile (git config --list --show-origin --show-scope drills into it more) it shows the file(s) to look at. I think .git/info/exclude is also possibly a repo-local exclude file to use, but I think that's kinda rare over a repo-root .gitignore.

@moshfeu
Copy link
Owner

moshfeu commented Sep 21, 2024

Thanks for the idea
The extension uses globby's isGitIgnoredSync and seems like somebody else liked your idea :)

I didn't dive into the issue there but someone suggested to take it a few months ago

In the meantime, you can exclude .DS_Store and other files using compareFolders.excludeFilter

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants