Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update utmost to utbase #288

Merged
merged 12 commits into from
Feb 18, 2020
Merged

Update utmost to utbase #288

merged 12 commits into from
Feb 18, 2020

Conversation

gulshanvasnani
Copy link
Collaborator

PR contains following changes :

  1. Added mint method in UtBase contract.
  2. Refactored unwrap method in UtBase contract.
  3. Added burn and burnFrom method in UtBase contract.
  4. Added unit test cases.

fixes #266

@deepesh-kn deepesh-kn self-assigned this Feb 18, 2020
deepesh-kn
deepesh-kn suggested changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Some minor documentation related changes are needed.

contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
test/consensus_cogateway/withdraw.js Outdated Show resolved Hide resolved
test/ut_base/burn.js Outdated Show resolved Hide resolved
@deepesh-kn deepesh-kn removed their assignment Feb 18, 2020
deepesh-kn
deepesh-kn suggested changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper post conditions.

contracts/consensus-gateway/ConsensusCogateway.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/utility-token/UtilityToken.sol Show resolved Hide resolved
test/ut_base/burn_from.js Outdated Show resolved Hide resolved
test/ut_base/mint.js Outdated Show resolved Hide resolved
test/ut_base/mint.js Outdated Show resolved Hide resolved
test/ut_base/burn.js Outdated Show resolved Hide resolved
test/ut_base/burn_from.js Outdated Show resolved Hide resolved
test/ut_base/burn.js Outdated Show resolved Hide resolved
deepesh-kn
deepesh-kn suggested changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done.

contracts/consensus-gateway/ConsensusCogateway.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
contracts/most/UtBase.sol Outdated Show resolved Hide resolved
@deepesh-kn deepesh-kn merged commit 036e6c8 into mosaicdao:develop Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepesh-kn deepesh-kn deepesh-kn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Utmost contract to UtBase
2 participants
@gulshanvasnani @deepesh-kn