Changed the function type of commitMetablock of Consensus contract from public to external #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om public to external
0xsarvesh
suggested changes
Feb 17, 2020
| // Anchor state root. | ||
| anchorStateRoot(_metachainId, _rlpBlockHeader); | ||
|
|
||
| CoreI core = assignments[_metachainId]; | ||
| bytes32 metablockHash = goToCommittedRound(_metachainId); |
There was a problem hiding this comment.
This is call twice in below functions :
- assertCommit
- commitStateRoot
| // Anchor state root. | ||
| anchorStateRoot(_metachainId, _rlpBlockHeader); | ||
|
|
||
| CoreI core = assignments[_metachainId]; |
There was a problem hiding this comment.
Core address is read three times. Is it possible to optimise this?
| * @param _gasTargetDelta Gas target delta to open new metablock. | ||
| * @param _kernelHash Kernel hash. | ||
| */ | ||
| function commitStateRoot( |
There was a problem hiding this comment.
It's more readable if event is emitted by external function instead of private.
| * @param _gasTargetDelta Gas target delta to open new metablock. | ||
| * @param _kernelHash Kernel hash. | ||
| */ | ||
| function commitStateRoot( |
There was a problem hiding this comment.
Naming can be improved.
|
As discussed with @deepesh-kn I am moving this ticket to parking lot. |
|
Thanks, but I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #245