Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover if Hilbert Detector's sparse detections is by design or flaw #32

Open
pmyers16 opened this issue Mar 31, 2021 · 0 comments
Open
Assignees

Comments

@pmyers16
Copy link
Collaborator

Describe the bug

The Hilbert Detector picks up way less HFO events than either of the RMS or LineLength Detectors. We need to figure out if this is by design or if it is a code bug before we use this in a study.

Steps to reproduce

Run the unit tests, pytest ./tests/test_detect.py::test_detect_hfo_hilbert and see that it misses detections

Expected results

We do not currently know what the expected output should be, so this might be right

Actual results

The first event is missed.

@pmyers16 pmyers16 self-assigned this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant