Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RMSDetector to have an option to compute envelope of the signal, rather than RMS #20

Open
adam2392 opened this issue Mar 1, 2021 · 1 comment
Open

Improve RMSDetector to have an option to compute envelope of the signal, rather than RMS #20

adam2392 opened this issue Mar 1, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adam2392
Copy link
Member

adam2392 commented Mar 1, 2021

  1. Implement compute_envelope in utils.py
  2. Add an option for metric = 'envelope' or metric = 'rms' in the intialization of RMSDetector
@adam2392 adam2392 added enhancement New feature or request good first issue Good for newcomers labels Mar 19, 2021
@pmyers16 pmyers16 changed the title Improve RMSDetector to have an option to compute envelope of the signal, rather then RMS Improve RMSDetector to have an option to compute envelope of the signal, rather than RMS Apr 2, 2021
@adam2392
Copy link
Member Author

@Stuart-2020 this would be a good second issue after tackling #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam2392