Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Table output #28

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

duckfarts
Copy link
Contributor

Please note that this also incorporates:

  • Fix: Fixes issue with creating tag pages for nested tags
  • Enhancement: Shows full link name instead of *

These needed to be included for the table output to work properly. Both of these are also available in separate pull requests.

Enhancement: Table output

  • Outputs links in tables instead of lists
  • Wildcard tag pages have separate tables for different links

Please note that tags that were used in bullet lists with additional bullets under them (hiearchically) create additional table rows on tag pages. i'd like to keep them in the same table cell using <br /> tags, but I haven't figured out how to do that yet.

Show full link name instead of *
Fixes issue with creating a file from nested tags by replacing / with _
Allows full link name to be shown instead of *
Changes link output from a list to a table
…ds to be merged with full link name enhancement.
Show full link name instead of *
Fixes issue with creating a file from nested tags by replacing / with _
Update tagSearch.ts to allow full link name
…r-nested

Duckfarts fix create tag page for nested
@GerkinDev
Copy link

GerkinDev commented Jun 6, 2024

Haha I've altered this same part of code, but using a Quote Callout, and grouping them by file.

image

I think that since we're 2 making changes on this part of the output, let's wait for the author decision & personnal touch.

Thinking out loud, just some ideas:
A more complex way to make everybody happy would be to give the choice to the user between multiple content formatters. Or maybe even loading a user-written .js file to do the formatting

@duckfarts
Copy link
Contributor Author

duckfarts commented Jun 7, 2024

Haha I've altered this same part of code, but using a Quote Callout, and grouping them by file.

image

I think that since we're 2 making changes on this part of the output, let's wait for the author decision & personnal touch.

Thinking out loud, just some ideas: A more complex way to make everybody happy would be to give the choice to the user between multiple content formatters. Or maybe even loading a user-written .js file to do the formatting

@GerkinDev I'll take a look at your changes, and I'm working on create a "Link output method" setting and trying to encase my changes accordingly. I'm not sure allowing a user-written .js file is a good idea off the bat though; it could work, but I don't know how much might break if it's really bad code.

Update: I just looked up what quote callouts do, and I think that this could be a separate enhancement that can co-exist with the other link output methods.

  • It seems like quote callouts are useful for visually encasing different groups of information
  • The information inside a quote callout can still be in a list or in a table

My idea for a table was just so the links or tags or whatever could be sorted, and maaaaaybe other metadata like Last Modified could be added to the table for sorting too (not there yet...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants