UI Selector to pop up at login one time per user #3271
+139
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9659582febf36baa594cde53edecfff6b181b693
ewpatton
reviewed
Dec 2, 2024
Comment on lines
+1794
to
+1796
| if(showUIPicker.equalsIgnoreCase("True")) { | ||
| new UISettingsWizard(true).show(); | ||
| } else if (AppInventorFeatures.showSplashScreen() && !isReadOnly) { |
There was a problem hiding this comment.
Note that if they choose Classic then the sequence of dialogs is broken here, since otherwise this would either call createWelcomeDialog or maybeShowNoProjectsDialog.
There was a problem hiding this comment.
No matter what is selected, the page reloads at this point, and the user should see Welcome/NoProjects.
There was a problem hiding this comment.
Hmm. I'm not sure that's ideal if they are already in the desired UI configuration but I guess we can keep it for now and see how it goes.
There was a problem hiding this comment.
The reload is included in saveUserDesignSettings, which I'm using to save the flag that the user has been shown this dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General items:
ant testspasses on my machineFor all other changes:
mastermasteras the baseWhat does this PR accomplish?
Description
Once for each user, pop up the User Interface selector with additional text to explain the new optional user interface. The user must select one UI or the other to proceed. This dialog pops up before the NoProjects dialog.
Resolves #3269