Implement a default uncaught exception handler #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Icb5517fad7968978e2a21a4de6078d1407308829
jisqyv
reviewed
Nov 3, 2024
appinventor/components/src/com/google/appinventor/components/runtime/Form.java
Outdated
Show resolved
Hide resolved
Change-Id: I9d06b4850aaf2ed3ac135254e6d14c07e5382cec
|
@jisqyv Here is a test app with an extension that just throws an error on another thread using AsynchUtil. |
jisqyv
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Icb5517fad7968978e2a21a4de6078d1407308829
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
Description
Fixes #3179 by setting a custom handler for when threads throw uncaught exceptions. Note that the behavior is different between Form and ReplForm, where the latter reports errors back to the editor via RetValManager.