Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password resets in the development environment #197

Open
jhsu802701 opened this issue Oct 4, 2018 · 4 comments
Open

Password resets in the development environment #197

jhsu802701 opened this issue Oct 4, 2018 · 4 comments

Comments

@jhsu802701
Copy link
Contributor

When I click on "Forgot Password?" for an account I created in the development environment, I get an error page with the error messages "Net::SMTPServerBusy in PasswordResetsController#create" and " Net::SMTPServerBusy in PasswordResetsController#create". This is because the src/config/environments/development.rb file is configured to require the Mandrill username and password.

I also noticed that there are no tests of the password reset process.

I will submit a pull request that removes this requirement from the development and test environments, and then I will submit a pull request that adds a test of the password reset process.

@jhsu802701
Copy link
Contributor Author

I'm putting this issue aside for now until we have other tests provided.

After the test suite provides a new password and clicks on "Update Password", I get the "ActionView::Template::Error" error message. The stumbling blocks are the "render partial" lines in app/views/participants/show.html.erb. Removing them allows the tests to pass, but this is not an acceptable option. It will be necessary to change these "render partial" lines, but it's essential to make sure that this doesn't cause other problems.

Therefore, I will fill in other tests before providing tests of the password reset process.

@jhsu802701
Copy link
Contributor Author

The participant show page chokes when there is no event and no sessions. The culprit is the "@participant.sessions_attending.for_current_event" part.

@jhsu802701
Copy link
Contributor Author

My solution to the participant show page problem is in Pull Request #200.

@jhsu802701
Copy link
Contributor Author

Luke Francl suggests fixing the for_current_event scope in src/app/models/session.rb .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant