Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BasicCarMaintenanceUITests testAddVehicle Fails #316

Open
mikaelacaron opened this issue Oct 2, 2024 · 1 comment · May be fixed by #348
Open

Fix BasicCarMaintenanceUITests testAddVehicle Fails #316

mikaelacaron opened this issue Oct 2, 2024 · 1 comment · May be fixed by #348
Assignees
@lexbonder
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed iOS Related to the iOS app

Comments

@mikaelacaron
Copy link
Owner

Describe the bug

  • The test testAddVehicle in BasicCarMaintenanceUITests fails

To Reproduce

Steps to reproduce the behavior:

  1. Run the unit test on an iOS simulator
  2. The test fails

Expected behavior

  • The test passes

Screenshots

N/A

Device Info (please complete the following information):

  • Device: any iOS simulator
  • OS: iOS 18 is where I found this, but it probably is failing for other iOS versions
  • App Version v1.0 (1)

Additional Context

  • This will still use XCTest, because it's a UI test. Sadly Swift Testing isn't supported for UI tests yet. And note that the UI test doesn't run as part of the tests in Fastlane (right now we're only running unit tests), and I want to keep it this way for now
@mikaelacaron mikaelacaron added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest iOS Related to the iOS app labels Oct 2, 2024
@lexbonder
Copy link

Hello. Can I give this one a go?

@lexbonder lexbonder linked a pull request Oct 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexbonder lexbonder

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed iOS Related to the iOS app
Projects
Basic Car Maintenance
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

316-Fix-BasicCarMaintenanceUITests lexbonder/Basic-Car-Maintenance
2 participants
@lexbonder @mikaelacaron