Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Medium Widgets, View Maintenance Events #50

Open
mikaelacaron opened this issue Oct 3, 2023 · 27 comments · May be fixed by #334
Open

FEATURE - Medium Widgets, View Maintenance Events #50

mikaelacaron opened this issue Oct 3, 2023 · 27 comments · May be fixed by #334
Assignees
Labels
feature request New feature or request good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed hold On hold for right now, not ready to be worked on

Comments

@mikaelacaron
Copy link
Owner

Describe the feature you want the app to have that it currently doesn't

  • Create a medium widget that allows you to view the total number of maintenance events for a specific vehicle
    Be able to configure which vehicle you want to view for this widget

Describe alternatives you've considered

N/A

Additional context

Only make the medium widget (I'll create new issues for adding different widget sizes later

@mikaelacaron mikaelacaron added feature request New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest labels Oct 3, 2023
@mikaelacaron
Copy link
Owner Author

@HarryHeres wanted to work on this, can you comment on this and I'll assign it to you

@mikaelacaron mikaelacaron changed the title FEATURE - FEATURE - Medium Widgets Oct 3, 2023
@HarryHeres
Copy link
Contributor

@mikaelacaron Yes, I’m done with the #7 for now, so I can work on this :)

@mikaelacaron
Copy link
Owner Author

Notice on dev I created the Widget extension now, to hopefully cut down on merge conflicts

@HarryHeres
Copy link
Contributor

Oh okay, thank you for the update!

@mikaelacaron mikaelacaron added the hold On hold for right now, not ready to be worked on label Oct 4, 2023
@mikaelacaron
Copy link
Owner Author

Sorry! This task isn't ready to be worked on right now, because I haven't connected the models together, feel free to choose another issue and I'll leave you as an assignee and let you know when you can come back to work on this issue

@HarryHeres
Copy link
Contributor

Okay, will stop working for the time being. Will be happy to continue once you've done the necessary features. Also, what models in particular are you referring to? Might be able to help out?

@mikaelacaron
Copy link
Owner Author

MaintenanceEvent and Vehhicle aren't connected, I would, but it might require how I am passing the models around, also I still need to change some Firebase rules

@mikaelacaron mikaelacaron moved this to In Progress in Basic Car Maintenance Oct 7, 2023
@mikaelacaron mikaelacaron changed the title FEATURE - Medium Widgets FEATURE - Medium Widgets, View Maintenance Events Oct 8, 2023
@HarryHeres
Copy link
Contributor

@mikaelacaron How are we doing with this?

@mikaelacaron
Copy link
Owner Author

Once #141 is done, you're ready! Thanks for your patience!
I was going to do it myself, but kinda got caught up, so I created an issue for someone else to work on this

@HarryHeres
Copy link
Contributor

Once #141 is done, you're ready! Thanks for your patience! I was going to do it myself, but kinda got caught up, so I created an issue for someone else to work on this

Awesome, will be looking forward to it!

@mikaelacaron
Copy link
Owner Author

This can be worked on now! Thanks so much for the patience

@HarryHeres
Copy link
Contributor

Awesome, will get to it ASAP!

@HarryHeres
Copy link
Contributor

HarryHeres commented Oct 15, 2023

@mikaelacaron Do you want me to create new separate class for the medium widget or just modify the sample BasicCarMaintenanceWidget source file?

Also, the widgets as provided at the moment, appear blank. I checked the code and it seems to me that it should be filled with couple of Simple Entries, each an hour apart (or a single entry as a placeholder). Or is there something I'm missing?

image

UPDATE: When migrated to StaticConfiguration and TimelineProvider, the widgets show their contents. Seems like a bug inside the WidgetKit. Any ideas if there's a solution to this?

@mikaelacaron
Copy link
Owner Author

UPDATE: When migrated to StaticConfiguration and TimelineProvider, the widgets show their contents. Seems like a bug inside the WidgetKit. Any ideas if there's a solution to this?

I'm not sure, it worked by default with the current code on my machine.

And yes go ahead and make a new class for the size

@HarryHeres
Copy link
Contributor

Have you tested in on a real device or in a simulator?

@mikaelacaron
Copy link
Owner Author

Both, for the default widget, they work for me

@HarryHeres
Copy link
Contributor

Hmm, okay, will try to inspect a bit more then.

@mikaelacaron
Copy link
Owner Author

Unfortunately I think I'm going to need to put this on hold again, because it's not going to filter properly, by vehicle, the way it's being saved right now

I thought it was, but looking at it closer I don't think it is

@HarryHeres
Copy link
Contributor

Okay, let me know when it gets resolved :)

@mikaelacaron
Copy link
Owner Author

Sorry 😅 I just noticed it last night, will post more soon

@HarryHeres
Copy link
Contributor

Sorry 😅 I just noticed it last night, will post more soon

No worries, take your time :)

@mikaelacaron
Copy link
Owner Author

Thanks for your patience! I'm going to hold off on all the widget tasks for right now because I'm going to change how the vehicles and maintenance events are connected. But because it's so close to the end of Hacktoberfest I don't want to break everything for everyone, so I'll open this issue again after Hacktoberfest and you're welcome to contribute to it for fun if you'd like

@github-project-automation github-project-automation bot moved this from In Progress to Done in Basic Car Maintenance Oct 24, 2023
@mikaelacaron mikaelacaron moved this from Done to Backlog in Basic Car Maintenance Oct 24, 2023
@mikaelacaron mikaelacaron moved this from Backlog to Todo in Basic Car Maintenance Oct 1, 2024
@mikaelacaron
Copy link
Owner Author

Opening this back up for Hacktoberfest 2024!

@mikaelacaron mikaelacaron reopened this Oct 1, 2024
@aking618
Copy link
Contributor

aking618 commented Oct 4, 2024

@mikaelacaron Can I work on this? It'll be fun trying out working with widgets.

@mikaelacaron
Copy link
Owner Author

@aking618 you got this! 🔥

@aking618
Copy link
Contributor

aking618 commented Oct 7, 2024

Progress Update:

I am able to load a user's vehicles as options for the widget and fetch maintenance events for them. Currently, I am hardcoding the user ID until I share the auth state with the widget.

image

Next Steps

  • Use the proper userID
  • Finalize the layout

@mikaelacaron
Copy link
Owner Author

@aking618 great! make sure it's flexible so that the others who are working on the other widgets can also use it

@aking618 aking618 linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed hold On hold for right now, not ready to be worked on
Projects
Development

Successfully merging a pull request may close this issue.

3 participants