Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPROVE - Connect WelcomeView and WelcomeViewAddVehicle to App Flow #285

Open
mikaelacaron opened this issue Jul 9, 2024 · 2 comments · May be fixed by #301
Open

IMPROVE - Connect WelcomeView and WelcomeViewAddVehicle to App Flow #285

mikaelacaron opened this issue Jul 9, 2024 · 2 comments · May be fixed by #301
Assignees
@maartinj
Labels
first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest improvement Improve an existing feature (like error handling)

Comments

@mikaelacaron
Copy link
Owner

Describe the feature you want to improve

  • WelcomeView and WelcomeViewAddVehicle have been created but aren't officially attached to the actual app flow.
  • Connect these two screens so that a user using the app for the first time will see the WelcomeView, and then push WelcomeViewAddVehicle after tapping continue
  • Change the "Welcome 🥳 " button to say "Add Vehicle"
  • Once Add Vehicle is tapped, dismiss this onboarding flow, and the user should see the DashboardView

Note

Don't actually write the code for adding the vehicle in Firebase, because I want to look closer at how this works (this is going to be broken in a different task), because the functionality is in the SettingsViewModel, which isn't accessible at this point)

Describe alternatives you've considered

N/A
@mikaelacaron mikaelacaron added the improvement Improve an existing feature (like error handling) label Jul 9, 2024
@mikaelacaron mikaelacaron added good first issue Good for newcomers first-timers-only Issues specifically for people who are new to open source labels Jul 9, 2024
@maartinj
Copy link
Contributor

maartinj commented Jul 9, 2024

@mikaelacaron I can take this opportunity and connect UI views with the App Flow 👍

@mikaelacaron
Copy link
Owner Author

@maartinj go for it!

@maartinj maartinj linked a pull request Aug 4, 2024 that will close this issue
Open
@mikaelacaron mikaelacaron added the hacktoberfest Any issue that can contribute to hacktoberfest label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maartinj maartinj

Labels
first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest improvement Improve an existing feature (like error handling)
Projects
Basic Car Maintenance
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Connect WelcomeView and WelcomeViewAddVehicle to App Flow maartinj/Basic-Car-Maintenance
2 participants
@mikaelacaron @maartinj