Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Odometer Reading Doesn't Update Properly #297

Open
mikaelacaron opened this issue Jul 30, 2024 · 8 comments
Open

BUG - Odometer Reading Doesn't Update Properly #297

mikaelacaron opened this issue Jul 30, 2024 · 8 comments
Assignees
Labels
bug Something isn't working first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed

Comments

@mikaelacaron
Copy link
Owner

Describe the bug

  • When editing the odometer reading, it doesn't update on the OdometerView after the EditOdometerReadingView is dismissed

To Reproduce

Steps to reproduce the behavior:

  1. Make sure you've added a vehicle
  2. Add an odometer reading
  3. Swipe left, and tap edit
  4. Edit the odometer reading amount
  5. Tap Update, and the view dismisses

Expected behavior

  • The OdometerView should see the updated value, but it's still showing the old value

Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-29.at.22.29.57.mp4

Device Info (please complete the following information):

  • Device: iPhone 15 Pro Simulator
  • OS: iOS 17.5.1
  • App Version v1.0

Additional Context

  • If you can do it without another network call that would be great, but if not, that's fine
@mikaelacaron mikaelacaron added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest first-timers-only Issues specifically for people who are new to open source labels Jul 30, 2024
@marvin-c-john
Copy link

Working on it

@mikaelacaron
Copy link
Owner Author

@marvin-c-john are you the person who I talked to on Reddit....?

@marvin-c-john
Copy link

@marvin-c-john are you the person who I talked to on Reddit....?

No sorry that was not me.

@mikaelacaron
Copy link
Owner Author

I created this issue specifically for a person on Reddit who's reached out to me, please close your PR, thank you

I'll be making this repo more active, with new issues for Hacktoberfest this year, but right now it's all kind of on pause, until then.

Thank you though for contributing!

@kianz20
Copy link

kianz20 commented Sep 23, 2024

@mikaelacaron considering nothing has happened for a few months is it OK to pick this up?

@mikaelacaron
Copy link
Owner Author

@kianz20 I'm going to make several new issues and have this repo be open for Hacktoberfest. I can assign it to you, but if you can wait until Hacktoberfest to contribute and make the PR that would be best!

It'll then count as a contribution for you! Does that sound good?

@kianz20
Copy link

kianz20 commented Sep 23, 2024

Sure :)

@mikaelacaron
Copy link
Owner Author

@kianz20 assigned to you! I'd wait to start working on it until October 1st because I'm going to be updating the repo a lot in the next few days in preparation for Hacktoberfest, but you're free to still look at it and figure out how you want to make the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working first-timers-only Issues specifically for people who are new to open source good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

3 participants