Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1236 Add Data Mover to Upstream e2e #782

Closed
wants to merge 2 commits into from
Closed

OADP-1236 Add Data Mover to Upstream e2e #782

wants to merge 2 commits into from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Aug 5, 2022 •
edited
Loading

OADP-1236

Closes migtools/volume-snapshot-mover#129

  • Add a test entry containing verification functions that
    • Discover and Install latest volsync via Operator catalog source either from go-client or via cli per official instruction and wait for it to be ready.
  • check app namespace events
    • check velero volumesnapshot/content events
    • check VSM volumesnapshot/content events
      snapshot status
      PVC events (data mover and volsync)
      volsync pod status
      replicationSource status
      VSB status
      VSM pod logs

Run backup and restore and check data per usual.

Additional fixes

  • Don't delete openshift-adp namespace after failure.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2022
@openshift-ci

This comment was marked as outdated.

Sign in to view
@kaovilai kaovilai force-pushed the datamovere2e branch 7 times, most recently from a068ae9 to 4ca0166 Compare August 15, 2022 19:31
@kaovilai kaovilai force-pushed the datamovere2e branch 6 times, most recently from 2097df6 to d8b621c Compare August 25, 2022 19:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022 •
edited
Loading

Codecov Report

Base: 33.79% // Head: 33.79% // No change to project coverage 👍

Coverage data is based on head (1201652) compared to base (7813e83).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   33.79%   33.79%           
=======================================
  Files          17       17           
  Lines        3128     3128           
=======================================
  Hits         1057     1057           
  Misses       1979     1979           
  Partials       92       92

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaovilai kaovilai force-pushed the datamovere2e branch 6 times, most recently from 3f37623 to 0413e0f Compare August 29, 2022 19:44
@kaovilai kaovilai marked this pull request as ready for review August 29, 2022 20:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2022
@kaovilai kaovilai force-pushed the datamovere2e branch 2 times, most recently from 8866d80 to c29afe2 Compare August 29, 2022 20:40
@hhpatel14

This comment was marked as outdated.

Sign in to view
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@kaovilai

This comment was marked as outdated.

Sign in to view
@kaovilai kaovilai force-pushed the datamovere2e branch 6 times, most recently from 94356ce to e8e74b8 Compare September 7, 2022 03:13
@kaovilai

This comment was marked as outdated.

Sign in to view
@kaovilai

This comment was marked as outdated.

Sign in to view
@kaovilai

This comment was marked as resolved.

Sign in to view
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2022
@kaovilai
Copy link
Member Author

kaovilai commented Nov 7, 2022 

        mongo-persistent:  error preparing volumesnapshots.snapshot.storage.k8s.io/mongo-persistent/velero-mongo-j5z96: rpc error: code = Aborted desc = plugin panicked: runtime error: index out of range [0] with length 0

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/782/pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-aws/1588756368683175936#1:build-log.txt%3A615

@kaovilai
Copy link
Member Author

kaovilai commented Nov 9, 2022

/test ci/prow/4.11-operator-e2e-aws

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

@kaovilai: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.10-ci-index
  • /test 4.10-images
  • /test 4.10-operator-e2e-aws
  • /test 4.10-operator-e2e-azure
  • /test 4.10-operator-e2e-gcp
  • /test 4.10-operator-unit-test
  • /test 4.11-ci-index
  • /test 4.11-images
  • /test 4.11-operator-e2e-aws
  • /test 4.11-operator-e2e-azure
  • /test 4.11-operator-e2e-gcp
  • /test 4.11-operator-unit-test
  • /test 4.8-ci-index
  • /test 4.8-images
  • /test 4.8-operator-e2e-aws
  • /test 4.8-operator-e2e-azure
  • /test 4.8-operator-e2e-gcp
  • /test 4.8-operator-unit-test
  • /test 4.9-ci-index
  • /test 4.9-images
  • /test 4.9-operator-e2e-aws
  • /test 4.9-operator-e2e-azure
  • /test 4.9-operator-e2e-gcp
  • /test 4.9-operator-unit-test

Use /test all to run all jobs.

In response to this:

/test ci/prow/4.11-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaovilai
Copy link
Member Author

kaovilai commented Nov 9, 2022

/test 4.11-operator-e2e-aws

@kaovilai
Copy link
Member Author

kaovilai commented Nov 9, 2022 •
edited
Loading

index out of range resolved with.

dataMoverImageFqin: '[quay.io/emcmulla/data-mover:fix1016](http://quay.io/emcmulla/data-mover:fix1016)' and csiPluginImageFqin: '[quay.io/spampatt/velero-plugin-for-csi:fix-1020-blocker-poll-11-8](http://quay.io/spampatt/velero-plugin-for-csi:fix-1020-blocker-poll-11-8)'

now issue is nil pointer dereference

"time=\"2022-11-09T03:59:04Z\" level=error msg=\"Namespace mysql-persistent, resource restore error: error preparing volumesnapshots.snapshot.storage.k8s.io/mysql-persistent/velero-mysql-nrwz2: rpc error: code = Aborted desc = plugin panicked: runtime error: invalid memory address or nil pointer dereference\" logSource=\"pkg/controller/restore_controller.go:531\" restore=openshift-adp/mysql-datamover-e2e-54f6332f-5fe2-11ed-bf31-0a580a8379fb",

@kaovilai
Add data mover to e2e
a0860e1 
Signed-off-by: Tiger Kaovilai <[email protected]>

override images

comment image overrides

Use 1.1 images + emcmulla/csi-plugin:latest

Signed-off-by: Tiger Kaovilai <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2022

@kaovilai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-operator-e2e-gcp 1201652 link true /test 4.10-operator-e2e-gcp
ci/prow/4.8-operator-e2e-aws 1201652 link true /test 4.8-operator-e2e-aws
ci/prow/4.11-operator-e2e-aws 1201652 link true /test 4.11-operator-e2e-aws
ci/prow/4.11-operator-e2e-azure 1201652 link true /test 4.11-operator-e2e-azure
ci/prow/4.10-operator-e2e-aws 1201652 link true /test 4.10-operator-e2e-aws
ci/prow/4.9-operator-e2e-aws 1201652 link true /test 4.9-operator-e2e-aws
ci/prow/4.10-operator-e2e-azure 1201652 link true /test 4.10-operator-e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai changed the title OADP-694 Add Data Mover to Upstream e2e OADP-1236 Add Data Mover to Upstream e2e Jan 31, 2023
@kaovilai kaovilai marked this pull request as draft January 31, 2023 18:13
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@kaovilai
Copy link
Member Author

duplicate of #955

@kaovilai kaovilai closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemcmullan eemcmullan eemcmullan approved these changes

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

@sseago sseago Awaiting requested review from sseago

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e test for data mover in OADP test suite
7 participants
@kaovilai @codecov-commenter @eemcmullan @shubham-pampattiwar @weshayutin @hhpatel14 @openshift-merge-robot