Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for InputGroup contents to ValidatedTextInput #55

Open
mturley opened this issue Apr 7, 2021 · 1 comment
Open

Add support for InputGroup contents to ValidatedTextInput #55

mturley opened this issue Apr 7, 2021 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. technical debt

Comments

@mturley
Copy link
Collaborator

mturley commented Apr 7, 2021

For kubev2v/forklift-ui#468, we needed to add a show/hide button attached to the password input fields by wrapping the TextInput in an InputGroup. Because ValidatedTextInput renders its own FormGroup internally, it doesn't give us the ability to customize the JSX around the inner TextInput, so I'm having to duplicate a version of ValidatedTextInput in forklift-ui temporarily.

After this issue is addressed, we should refactor forklift-ui's ValidatedPasswordInput component to use the new functionality, and possibly bring that component in to lib-ui as well.
@mturley mturley added kind/feature Categorizes issue or PR as related to a new feature. technical debt labels Apr 7, 2021
@mturley mturley mentioned this issue Apr 7, 2021
Merged
@mturley
Copy link
Collaborator Author

mturley commented Apr 7, 2021

See kubev2v/forklift-ui#524 for implementation details of the InputGroup pattern we should support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mturley