You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The StatusCondition component in forklift-ui (https://github.com/konveyor/forklift-ui/blob/main/src/app/common/components/StatusCondition.tsx) should be cleaned up and moved here. It's almost generic enough already, but some of the helper function logic is a little redundant and arbitrary in places. If we make it truly be able to handle a generic set of status conditions on any CR, it could be a very useful component.
I think the main pain point is the mapping of condition severities/types to colors/icons. In forklift, there isn't a perfect mapping and we need to make some assumptions that may not match the behavior of other apps. We could improve that default logic but maybe also add a way of passing your own getStatusType function (given a condition object, which icon should we use) in case apps need to override it.
The text was updated successfully, but these errors were encountered:
The
StatusCondition
component in forklift-ui (https://github.com/konveyor/forklift-ui/blob/main/src/app/common/components/StatusCondition.tsx) should be cleaned up and moved here. It's almost generic enough already, but some of the helper function logic is a little redundant and arbitrary in places. If we make it truly be able to handle a generic set of status conditions on any CR, it could be a very useful component.I think the main pain point is the mapping of condition severities/types to colors/icons. In forklift, there isn't a perfect mapping and we need to make some assumptions that may not match the behavior of other apps. We could improve that default logic but maybe also add a way of passing your own
getStatusType
function (given a condition object, which icon should we use) in case apps need to override it.The text was updated successfully, but these errors were encountered: