Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: GLab.GLab version 1.23.1 #90349

Merged
1 commit merged into from
Dec 2, 2022

Conversation

viktomas
Copy link
Contributor

@viktomas viktomas commented Dec 2, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: manifests/g/GLab/GLab/1.23.1 is the name of the directory containing the manifest you're submitting.


Apart from updating the package, this PR also changes the origin (ownership) of the manifest

GitLab is now the official maintainer of the glab package.

I've made a similar PR for

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello @viktomas,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 2, 2022
@ghost ghost assigned viktomas Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello @viktomas,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@russellbanks
Copy link
Contributor

As a side note, please update your clone of winget-pkgs. The YamlCreate you're using is a bit outdated.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Dec 2, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@viktomas
Copy link
Contributor Author

viktomas commented Dec 2, 2022

As a side note, please update your clone of winget-pkgs. The YamlCreate you're using is a bit outdated.

@russellbanks Ok, I updated to the latest master but there have been only 4 commits in it since I cloned it half an hour ago.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Dec 2, 2022

viktomas,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@russellbanks
Copy link
Contributor

As a side note, please update your clone of winget-pkgs. The YamlCreate you're using is a bit outdated.

@russellbanks Ok, I updated to the latest master but there have been only 4 commits in it since I cloned it half an hour ago.

The YamlCreate in your fork is the correct version but this PR was created with 2.0.4 so I'm not sure

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello viktomas,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello viktomas,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit bc3285f into microsoft:master Dec 2, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants