Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions don't appear to work in .vue files #39939

Closed
hecktarzuli opened this issue Dec 8, 2017 · 7 comments
Closed

Regions don't appear to work in .vue files #39939

hecktarzuli opened this issue Dec 8, 2017 · 7 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension
Milestone

Comments

@hecktarzuli
Copy link

hecktarzuli commented Dec 8, 2017

  • VSCode Version: Code 1.18.1 (929bacb, 2017-11-16T18:32:36.023Z)
  • OS Version: Windows_NT x64 10.0.14393
  • Extensions:
Extension Author (truncated) Version
vetur oct 0.11.3
vue-vscode-snippets sdr 1.2.0

(1 theme extensions excluded)

Steps to Reproduce:

  1. Create a .vue file with a <script> tag in it
  2. Try to create a region, example: //#region var JoshIsCool = false;//#endregion
  3. Notice no folding activates
  4. Cry yourself to sleep

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Dec 8, 2017
@octref
Copy link
Contributor

octref commented Dec 8, 2017

@mjbvz HTML folding regions seem to be picked up, but JS/TS only pick up some of them (not including #region ones.

Wondering if that's because the region markers are dynamically computed and controlled by TypeScript LS? (remember hearing something like this).

image

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 8, 2017

No. The TS language is not involved in regions, it's just a language configuration we set for JS/TS. @aeschli would know more about this

@hecktarzuli
Copy link
Author

FYI, I'm not using TS

@jordan-erisman
Copy link

jordan-erisman commented Aug 29, 2018

Doesn anyone have a fix for this? Regions do not working the template (html) section either. Folding works, just not regions.

@ashishmit14
Copy link

Facing this same problem here. Feel bad for the commented codes.

@octref octref added this to the Backlog milestone Aug 30, 2018
@octref octref added *caused-by-extension Issue identified to be caused by an extension and removed extensions Issues concerning extensions labels Sep 10, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 10, 2018

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 10, 2018
@octref
Copy link
Contributor

octref commented Sep 10, 2018

Tracking in vuejs/vetur#899.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Development

No branches or pull requests

5 participants