Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the windows download needs an "alternative" #39

Open
connor4312 opened this issue Mar 21, 2023 · 1 comment
Open

Why the windows download needs an "alternative" #39

connor4312 opened this issue Mar 21, 2023 · 1 comment

Comments

@connor4312
Copy link
Member

        // This alternative strategy shouldn't be necessary but sometimes on Windows the file does not get closed,
        // so unzipping it fails, and I don't know why.

I think this is because the promise resolves on('finish' of the outFile. This is when contents have been written, but the file is not yet closed. Changing that to on('close' should resolve the issue.

Ref https://nodejs.org/api/fs.html#filehandlecreatewritestreamoptions

@ghost
Copy link

ghost commented Jun 10, 2023

"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant