Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions end up in unsubmittable pending state #6494

Open
MetRonnie opened this issue Nov 19, 2024 · 0 comments
Open

Suggestions end up in unsubmittable pending state #6494

MetRonnie opened this issue Nov 19, 2024 · 0 comments

Comments

@MetRonnie
Copy link

MetRonnie commented Nov 19, 2024

  • Extension version: v0.100.0
  • VSCode Version: 1.95.3 (system setup)
  • OS: Windows_NT x64 10.0.19045
  • Repository Clone Configuration: fork of an upstream repository
  • Github Product: Github.com

Steps to Reproduce:

  1. Make multiple changes to different "hunks" in a file and click the "Create pull request suggestions" button in the Source Control panel

    Here my suggestions ended up as 4 pending comments:

    gh-pr-bug-3-p1.mp4
  2. This can lead to multiple individual reviews being started on GitHub and only being able to submit a subset of the suggestions in the review

    On the GH website only 1 comment is in the review:

    gh-pr-bug-3-p2.mp4

    The other comments end up stuck as pending and cannot be submitted in a review

This is superficially similar to #4291, but in this case the comments clearly are making their way to the server in the pending state, but cannot be submitted.

#1317 may also be relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant