Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On PR to submodule parent package was forked instead of submodule #6492

Open
3y3 opened this issue Nov 19, 2024 · 0 comments
Open

On PR to submodule parent package was forked instead of submodule #6492

3y3 opened this issue Nov 19, 2024 · 0 comments

Comments

@3y3
Copy link

3y3 commented Nov 19, 2024

  • Extension version: v0.100.1
  • VSCode Version: 1.9.3
  • OS: MacOS
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository with submodules
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

tl;dr: On PR create for submodule, extension will fork main repository instead of submodule.
Looks like it's the same as
#4487
#5181

We found issue on diplodoc metapackage. But it is reproducible on any repo with submodules.

Prerequisites:
Metapackage - organisation owned repo with submodules and enabled codespaces.
Submodule - any organisation owned repo linked to metapackage.
Alice - user out of organization scope.

  1. Create codespace for metapackage and open it in browser VSCode
  2. Pull submodules. We use this small script to pull all submodules in one time, but looks like there is nothing special.
  3. Make some change to submodule.
  4. Create new branch in submodule. Commit changes (with help of Github Pull Request Extension)
  5. Push the button "Create Pull Request" Image
  6. Check autofilled fields (looks like at this step all is normal: BASE and MERGE fields refers to submodule branches)
  7. Push "Create" button.
  8. VSCode notifies Alice about restriction to pull directly to organization and proposes to create fork.
  9. Submit to fork submodule
    9.1 Current behaviour: fork for metapackage was created, pr flow was broken on next step with reasonable error.
    Image
    9.2 Expected behaviour: fork for submodule was created, pr flow finished succesefully.
  10. At second try to push "Create" button error message was changed to
    Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant