Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestOptions should be made required if a convenience method is added in later version #5122

Open
JoshLove-msft opened this issue Nov 15, 2024 · 1 comment
Open

RequestOptions should be made required if a convenience method is added in later version #5122

JoshLove-msft opened this issue Nov 15, 2024 · 1 comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

JoshLove-msft commented Nov 15, 2024 •
edited
Loading

The RequestOptions parameter can therefore be optional as there is no chance of conflict.
@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 15, 2024
@JoshLove-msft JoshLove-msft changed the title All parameters should be required on protocol methods that don't have a BinaryContent parameter Bodyless operations should only have one method for both convenience/protocol. Nov 15, 2024
@JoshLove-msft
Copy link
Contributor Author

JoshLove-msft commented Nov 18, 2024 •
edited
Loading

Upon further discussion, the decision was to leave RequestOptions as optional for the protocol-only scenario. If a convenience method is later added, the RequestOptions can be made required in the new version. Leaving this open as this would need to be tackled as part of the last contract work.

@JoshLove-msft JoshLove-msft changed the title Bodyless operations should only have one method for both convenience/protocol. RequestOptions should be made required if a convenience method is added in later version Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshLove-msft