Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary namespace for type from shared files in generated SDK #5104

Closed
live1206 opened this issue Nov 14, 2024 · 2 comments · Fixed by #5171
Closed

Unnecessary namespace for type from shared files in generated SDK #5104

live1206 opened this issue Nov 14, 2024 · 2 comments · Fixed by #5171
Assignees
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@live1206
Copy link
Contributor

We have shared files included into compile, the types in them are generated with full namespace.
Azure/azure-sdk-for-net#47136 (comment)

@live1206 live1206 added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 14, 2024
@pshao25
Copy link
Contributor

pshao25 commented Nov 14, 2024

The thing more important than removing the namespace is we should make sure we are referring the one from shared code, not the one from the azure.core package.

@live1206
Copy link
Contributor Author

The thing more important than removing the namespace is we should make sure we are referring the one from shared code, not the one from the azure.core package.

I don't think this would happen. If we have same type from shared code and public package, it won't compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants