Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions should be aware of string literals #2000

Open
minestarks opened this issue Nov 1, 2024 · 0 comments
Open

Completions should be aware of string literals #2000

minestarks opened this issue Nov 1, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@minestarks
Copy link
Member

Completions have buggy behavior in the following cases:

Should show completions, but are suppressed due to naive check for line comments:

let x = "// comment" + |

Should NOT show completions, but do today:

let x = "foo.|"

See #1999 for some context

@minestarks minestarks added bug Something isn't working needs triage labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant